Retrieve :nth-child nodes by identity #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the `:nth-child`/`:nth-of-type` selectors find siblings through the `Core.:(===)` operator. This is the same behaviour as `nextSibling` and `prevSibling`. Closes Algocircle#21.
|
Hmm... I think it's reasonably safe to assume that nodes are not copied within a single Cascadia run .. we just go with what |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the
:nth-child/:nth-of-typeselectors find siblingsthrough the
Core.:(===)operator. This is the same behaviour asnextSiblingandprevSibling.Closes #21.
Passes tests locally.
I would appreciate eyeballs on this, I got the idea for this fix by noticing what
nextSiblingandprevSiblingdo:Cascadia.jl/src/selector.jl
Line 20 in 64cbcf6
As I understand it, because Gumbo.jl’s data takes the form of mutable structs using
===is reliable only if nodes are not copied. I don’t know enough about the ecosystem to figure out if that makes this PR sensible.