Fix #2945: Persistent workspace disappear after being active

[zjeffer]

If a user has a persistent workspace waybar config, and then switches to an empty workspace that is configured as persistent in the config, that empty workspace will be recreated with persistency disabled.

This PR fixes this by not updating the persistency. In hindsight this line was never really needed in the first place.

[aruhier]

I think you might prefer this:

  if (workspace != m_workspaces.end()) {
    // don't recreate workspace, but update persistency if necessary
    //
    // An update is necessary only when the persistency was false and is now true. The update
    // of the persistency in Hyprland should not trigger a workspace creation.
    // Without this check, the persistency set in the waybar config will be overridden by the one
    // set in Hyprland when Hyprland creates the workspace.
    if (!(*workspace)->isPersistent()) {
      (*workspace)->setPersistent(workspace_data["persistent"].asBool());
    }
    return;
  }

[aruhier]

I updated my comment as it was misleading. Hyprland doesn't send any event for the creation/update of a rule of a workspace, therefore updating persistent in Hyprland will not trigger anything in Waybar. It'll however trigger the removal of the workspace if it's persistency is updated to false and the workspace is empty.

Therefore, I think it's good for now to support only updating from non persistent to persistent, which would work in most cases.

I proposed an in my opinion better option in #2603 (comment), but it will be maybe a bit longer to implement.

[zjeffer]

Closing in favour of #2967