hyprland/workspaces: Persistent workspace disappear after being active

[aruhier]

Hi,
With commit 11310b8, a workspace set as persistent is not shown anymore after being active and then destroyed by Hyprland.

Config:

    "hyprland/workspaces": {
        "all-outputs": true,
        "format": " {icon}",
        "persistent-workspaces": {
            "*": [1, 2, 3, 4, 5, 6, 7, 8]
        },
    },

How to reproduce:

1. Start waybar with persistent workspaces. All persistent workspaces are shown correctly at start. Using my config above, it'll show this:
   
2. Switch to a an empty workspace in Hyprland, set as persistent in waybar. For example, switching to i, it works as intended:
   
3. Switch to another workspace in Hyprland. Workspace i is destroyed in Hyprland, and not persistent anymore in Waybar (it is not listed anymore):
   

Reverting commit 11310b8 fixes this behavior.
CC @zjeffer for the #2603.

Edit: I forgot to specify that I don't set my workspaces as persistent in Hyperland, only in Waybar.

[zjeffer]

Thanks for the detailed report.

I might have time to look into this tomorrow. In the meantime, can you post the trace logs where you start the bar and do the exact things to reproduce this issue?

[zjeffer]

Nevermind, I can reproduce the issue locally. Will investigate.

[zjeffer]

Can you test that PR @aruhier ?

[aruhier]

Thanks!

It works better, but now the bug is more specific. If a persistent workspace is active when you start Waybar, then get empty (and removed by Hyprland) the problem occurs for this workspace.

Otherwise, workspaces that are empty when Waybar starts don't have the problem anymore.

[aruhier]

I found the problem and I think I fixed it, I added a comment in your PR.

[aruhier]

Do you set the workspace as persistent in Hyprland or only in Waybar?

[zjeffer]

I personally set it to persistent in Hyprland.

The code is written in such a way that you shouldn't use both methods. You should either specify persistent workspaces in your waybar config, or specify them in your Hyprland config. No mixing.

[aruhier]

I'm asking this because not setting it in Hyprland is when the PR didn't work, compared to what I proposed. Because the workspace exists in Hyprland, it'll be created by initializeWorkspaces(), but the persistency is not set in Waybar. Then because the workspace already exists in Waybar, the persistency state is not set with this PR.

If you set the workspace as persistent in Hyprland, then the workspace is never removed, which hides the issue.

[aruhier]

I wrote #2967, that fixes this bug.

The code is written in such a way that you shouldn't use both methods. You should either specify persistent workspaces in your waybar config, or specify them in your Hyprland config. No mixing.

Tell me if I'm wrong, but it should also fix this. Waybar will prefer the persistency state set in the config compared to the one set in Hyprland, but the 2 methods should work well together.