Improve cache key defaults for menus #2138 #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the currently generated templates the way menus are being displayed depends on the (current) page and whether one is in preview mode or not. Thus both facts should probably go in the cache key as well.
tvdeyen
approved these changes
Jul 10, 2021
tvdeyen
added a commit
that referenced
this pull request
Sep 15, 2021
- Return only pages from current site in api [#2169](#2169) ([afdev82](https://github.com/afdev82)) - Improve cache key defaults for menus #2138 [#2160](#2160) ([oneiros](https://github.com/oneiros)) - generate picture thumbnails only for pictures with convertible format [#2130](#2130) ([afdev82](https://github.com/afdev82)) - Backport #2114 to v5.2 [#2116](#2116) ([afdev82](https://github.com/afdev82)) - Add webpacker tasks to Alchemy upgrader [#2115](#2115) ([dbwinger](https://github.com/dbwinger))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #2153 this is the very same change for 5.2-stable.
If you plan to release another point release for 5.2 before releasing version 6 this makes total sense to me. New projects will still use 5.2 until version 6 is available. And I expect menus to be generated relatively early on when setting up a new project.
With that being said, do you still think this should be ported even further back?
Will people still start new projects with 5.1 for example? Will people who have been on 5.1 for a long time and never made the jump to 5.2 upgrade to a new point release of 5.1 and then generate new menus?