Improve cache key defaults for menus #2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the currently generated templates the way menus are being displayed depends on the (current) page and whether one is in preview mode or not. Thus both facts should probably go in the cache key as well.
|
@oneiros mind open additional PRs for 5.0, 5.1 and 5.2? I think we need to backport this far back :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
With the currently generated templates the way menus are being displayed depends on the (current) page and whether one is in preview mode or not.
This PR adds both facts to the cache key used in the generator's templates.
Closes #2138
Notable changes (remove if none)
This only affects newly generated menu templates.
Checklist
Sorry, I have no idea if this even needs test and if yes, how this could be tested. If you have suggestions, please let me know and I will gladly add something.