Rails 5 support #1125

tvdeyen · 2016-09-11T16:06:19Z

Rails 5 support

As with mayor Rails updates before, we plan to support Rails 5 with the next mayor version of Alchemy (4.0).

This PR is an ongoing process to make the necessary changes.

houndci-bot · 2016-09-11T16:06:41Z

lib/alchemy/touching.rb

@@ -2,7 +2,7 @@ module Alchemy
  module Touching
    # Touches the timestamps and userstamps
    #
-    def touch
+    def touch(*names, time: nil)


Unused method argument - names. If it's necessary, use _ or names as an argument name to indicate that it won't be used. You can also write as touch() if you want the method to accept any arguments but don't care about them.
Unused method argument - time. You can also write as touch(_) if you want the method to accept any arguments but don't care about them.

hyiltiz · 2017-01-04T22:11:46Z

Any estimates on when Rails 5 will be fully supported?

tvdeyen · 2017-01-05T08:50:22Z

@hyiltiz unfortunately not yet. Working on it. Any help is appreciated.

houndci-bot · 2017-01-23T13:41:24Z

spec/requests/alchemy/legacy_page_redirecting_spec.rb

+  let(:legacy_url4) do
+    Alchemy::LegacyPageUrl.create(
+      urlname: 'index.php?option=com_content&view=article&id=48&Itemid=69',
+      page: second_page)


Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

fastjames · 2017-03-10T21:14:33Z

I pulled down this branch and ran the test suite locally, and came up with 0 failures (yay!). If the mysql failures in travis were fixed, would this branch be considered for merge prior to 4.0? I'm not planning to use mysql, but if I can help with making it work I don't mind doing so.

fastjames · 2017-03-10T22:29:11Z

I was able to replicate the failures with mysql, and they all seem to tie to expected changes to timestamp fields. After some research, I found a patch to rails to enable subsecond resolution for MySQL timestamps so I'm not sure why it does not seem to happen here. The good news is that all 17 failures I saw seem to center around this problem, so one fix will probably green them all.

fastjames · 2017-03-10T22:32:50Z

As expected, something is truncating the fractional seconds:

jkane@KingOfTown:~/src/alchemy_cms(rails-5*)% DB=mysql rspec spec/controllers/alchemy/admin/essence_files_controller_spec.rb:70
Run options: include {:focus=>true, :locations=>{"./spec/controllers/alchemy/admin/essence_files_controller_spec.rb"=>[70]}}
before: content updated_at is 2017-03-10 22:30:47.000000000
after: content updated_at is 2017-03-10 22:30:47.000000000

fastjames · 2017-03-10T22:39:53Z

According to The MySQL docs the default precision for datetime fields is 0.

I'm happy to create migrations that explicitly set the precision on all timestamp fields to 6. That should match with what postgresql already does, while bringing mysql up to speed.

fastjames · 2017-03-10T22:53:25Z

Verified: adding full precision to a test column made the tests related to that column pass. I'll build a migration for all of them and submit it.

tvdeyen · 2017-03-10T23:22:50Z

Thanks. This is really helpful. I think using a higher precision on timestamps just for MySQL is not what we want to maintain. Instead we should try to fix the specs.

would this branch be considered for merge prior to 4.0

I want to have feature parity between current (yet unreleased) 3.6 and 4.0 (Rails 5 compatible version of Alchemy. Therefore we need to release a 3.6 first. This version needs to include deprecation warnings for stuff we need to change for Rails 5. There is still lot to do.

Unfortunately, my time for working on Alchemy is very limited. So, this will take some time.

Thanks for looking into the MySQL stuff.

fastjames · 2017-03-13T14:59:55Z

@phoet did you supply the DB=mysql env var when running the tests? I was able to produce the fails on a fresh install (and a fresh fork) by adding that config tweak.

mtomov · 2017-03-15T15:38:59Z

Wow, it's just brilliant how small this PRs, and 70% of the changes are to the dummy app. Great one on bringing the rails 4 alchemy so up to date!

Actually, am I missing something or there isn't a single line of non-test code change in there, which is not Rails 5 specific?

Then what deprecations warning do you want to put in place Thomas? Maybe for some old PRs, which have made a deprecation without documenting it?

mtomov · 2017-03-24T14:18:47Z

I want to have feature parity between current (yet unreleased) 3.6 and 4.0 (Rails 5 compatible version of Alchemy. Therefore we need to release a 3.6 first. This version needs to include deprecation warnings for stuff we need to change for Rails 5. There is still lot to do.

Sorry, just wanted to ask if I can help out with writing out those deprecation warnings, or would it be too much to explain?

etewiah · 2017-03-29T10:53:32Z

Great that Rails 5 support is almost ready! I'm looking forward to using Alchemy as the content management part of a real estate website builder I'm working on.

Thanks for all the great work.

mikel · 2017-06-06T10:57:36Z

Hey there @tvdeyen, from what I can read, the roadmap to Rails 5 support is:

get a list of deprecations to put into a yet unreleased 3.6 version
publish a 3.6 version
publish a 4.0 version based on this branch

Would that summarise what is needed? If so, I can get a developer perhaps from my company to help push this through. Please let me know.

tvdeyen · 2017-06-20T08:31:16Z

@mikel yes, this is how I plan to do this.

Thanks for your offer, this is very much appreciated, but you can't actually gems, so I have to do this. But due to lack of time I can't really make this soonish. I don't want to rush this either, as releasing open source software has to be done carefully, for that I need some time to concentrate on.

This is not very satisfy for you, I see that.

You could help us by testing the rails-5 branch in your sites. This is pretty much the same feature set as Alchemy 3.5 with mostly changes to the test suite. So this should be ready for production. Testing this in your sites would really help us to iron out potential issues.

Rails 5 only supports 2.2.2+, so we.

It is not needed any more with sprockets-rails 3.1

Rails 5 has dropped support for `assign` and `assert_template` methods.

Rails 5 now wants the database environment set.

With Rails 5 the supported Ruby version was raised to 2.2.2 Adjust the travis configuration to build with Ruby 2.2.6, 2.3.3 and 2.4.0

tvdeyen · 2017-06-20T15:16:56Z

@mamhoff just released 3.6, so this is now finally ready to be merged 🎊

mamhoff

Looks good to me! Thanks to everyone involved!

mtomov · 2017-06-20T18:28:15Z

Wooow, so sooon? Wow, I really didn't expect it for another few months after your message. Thanks so much all!!

I am really excited about the updated UI in #1261 , so now that this one is merged, I will see to help out there! Thanks again all!

tvdeyen · 2017-06-20T19:01:30Z

Haha, yeah. I wanted to have this finally done myself. Very annoying to have al this TODOs laying around.

mtomov · 2017-06-20T19:28:29Z

Absolutely, know the feeling. Thanks again!

tvdeyen added this to the 4.0 milestone Sep 11, 2016

tvdeyen self-assigned this Sep 11, 2016

tvdeyen added the in progress label Sep 11, 2016

houndci-bot reviewed Sep 11, 2016
View reviewed changes

tvdeyen force-pushed the rails-5 branch 3 times, most recently from efab654 to 08ceef8 Compare September 13, 2016 18:03

tvdeyen force-pushed the rails-5 branch 3 times, most recently from 6b46ea2 to fecfb61 Compare October 7, 2016 07:01

tvdeyen force-pushed the rails-5 branch from 97b203d to 77a725c Compare October 12, 2016 18:26

tvdeyen force-pushed the rails-5 branch from 77a725c to 87d20f5 Compare November 6, 2016 12:29

tvdeyen force-pushed the rails-5 branch from 87d20f5 to a127ad8 Compare November 21, 2016 20:54

tvdeyen force-pushed the rails-5 branch from c692d26 to 4d63378 Compare January 5, 2017 08:47

tvdeyen force-pushed the rails-5 branch 4 times, most recently from db4a0e4 to 2d17e9a Compare January 8, 2017 22:01

houndci-bot reviewed Jan 23, 2017

View reviewed changes

tvdeyen force-pushed the rails-5 branch 3 times, most recently from f2409aa to 92e314f Compare February 24, 2017 18:30

tvdeyen force-pushed the rails-5 branch from d795962 to 2afef6a Compare June 20, 2017 12:04

Thomas von Deyen and others added 11 commits June 20, 2017 14:14

Work with Rails >= 5.0 only

f70610c

Raise required Ruby version to 2.2.2

6d99029

Rails 5 only supports 2.2.2+, so we.

Remove quiet_assets gem

9ada46f

It is not needed any more with sprockets-rails 3.1

Update dummy app to Rails 5

b1a85d2

Add rails-controller-testing gem

b2c0303

Rails 5 has dropped support for `assign` and `assert_template` methods.

Silence deprecations for now

2fe2554

Update prepare spec task for Rails 5

4ce713a

Rails 5 now wants the database environment set.

Updates dummy app schema

336840b

Updates spring bin stub

8298cad

Raise if unpermitted params get accessed in test env

a9458a4

Only build supported ruby versions

908ed0d

With Rails 5 the supported Ruby version was raised to 2.2.2 Adjust the travis configuration to build with Ruby 2.2.6, 2.3.3 and 2.4.0

tvdeyen force-pushed the rails-5 branch from e618d5c to 908ed0d Compare June 20, 2017 12:14

tvdeyen changed the title ~~WIP: Rails 5 support~~ Rails 5 support Jun 20, 2017

tvdeyen removed their assignment Jun 20, 2017

tvdeyen requested a review from mamhoff June 20, 2017 15:16

tvdeyen removed the in progress label Jun 20, 2017

mamhoff approved these changes Jun 20, 2017

View reviewed changes

tvdeyen merged commit d63cc66 into master Jun 20, 2017

tvdeyen deleted the rails-5 branch June 20, 2017 19:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rails 5 support #1125

Rails 5 support #1125

tvdeyen commented Sep 11, 2016

houndci-bot Sep 11, 2016

hyiltiz commented Jan 4, 2017

tvdeyen commented Jan 5, 2017

houndci-bot Jan 23, 2017

fastjames commented Mar 10, 2017

fastjames commented Mar 10, 2017

fastjames commented Mar 10, 2017

fastjames commented Mar 10, 2017

fastjames commented Mar 10, 2017

tvdeyen commented Mar 10, 2017

fastjames commented Mar 13, 2017

mtomov commented Mar 15, 2017 •

edited

Loading

mtomov commented Mar 24, 2017

etewiah commented Mar 29, 2017

mikel commented Jun 6, 2017

tvdeyen commented Jun 20, 2017

tvdeyen commented Jun 20, 2017

mamhoff left a comment

mtomov commented Jun 20, 2017

tvdeyen commented Jun 20, 2017

mtomov commented Jun 20, 2017

Rails 5 support #1125

Rails 5 support #1125

Conversation

tvdeyen commented Sep 11, 2016

Rails 5 support

houndci-bot Sep 11, 2016

Choose a reason for hiding this comment

hyiltiz commented Jan 4, 2017

tvdeyen commented Jan 5, 2017

houndci-bot Jan 23, 2017

Choose a reason for hiding this comment

fastjames commented Mar 10, 2017

fastjames commented Mar 10, 2017

fastjames commented Mar 10, 2017

fastjames commented Mar 10, 2017

fastjames commented Mar 10, 2017

tvdeyen commented Mar 10, 2017

fastjames commented Mar 13, 2017

mtomov commented Mar 15, 2017 • edited Loading

mtomov commented Mar 24, 2017

etewiah commented Mar 29, 2017

mikel commented Jun 6, 2017

tvdeyen commented Jun 20, 2017

tvdeyen commented Jun 20, 2017

mamhoff left a comment

Choose a reason for hiding this comment

mtomov commented Jun 20, 2017

tvdeyen commented Jun 20, 2017

mtomov commented Jun 20, 2017

mtomov commented Mar 15, 2017 •

edited

Loading