Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #45

Closed
wants to merge 1 commit into from
Closed

Update README.md #45

wants to merge 1 commit into from

Conversation

ishaq
Copy link
Contributor

@ishaq ishaq commented Oct 28, 2015

added clarification for #35

added clarification for Alamofire#35
cnoon pushed a commit that referenced this pull request Oct 28, 2015
@cnoon
Copy link
Member

cnoon commented Oct 28, 2015

Thanks for your PR @ishaq! I've merged a modified version of this PR in f664428 giving you attribution. I removed the example code because I thought it may be a bad idea to show code in the README that doesn't actually work. Unfortunately, people tend to copy code samples and not read the descriptions.

Thanks again for this! 🍻

@cnoon cnoon closed this Oct 28, 2015
@cnoon cnoon self-assigned this Oct 28, 2015
@cnoon cnoon added this to the 2.2.0 milestone Oct 28, 2015
@ishaq
Copy link
Contributor Author

ishaq commented Oct 28, 2015

👍

@cnoon cnoon modified the milestones: 2.2.0, 2.1.1 Nov 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants