Downloading doesn't work via ImageDownloader

[kafejo]

let downloader = ImageDownloader()
let URLRequest = NSURLRequest(URL: NSURL(string: "https://httpbin.org/image/jpeg")!)

downloader.downloadImage(URLRequest: URLRequest) { response in
    if let image = response.result.value {
        print(image)
    }
}

The completion block isn't even called. Using Alamofire image response serializer works fine.

[cnoon]

Your downloader is going out of scope. There are MANY tests verifying that the ImageDownloader does in fact work.

[ishaq]

would it be a good idea to highlight this somewhere in the documentation? I stumbled upon the same bug just now. while I understand it's programmer's fault here (downloadImage being an instance function rather than a static function, so it should imply saving the instance somewhere, correct?). I think since people are used to Alamofire.request (static function), they absent mindedly expect the same from ImageDownloader.

NOTE: the word bug above implies bug in my code, not in AlamofireImage :-)

[cnoon]

Would you mind looking through the documentation in the ImageDownloader Section of the README to give a more specific suggestion on where to provide that info?

[ishaq]

sure (in a couple of hours from now), would it be okay if I make the change and send PR?

[cnoon]

That would be great!