adding 'zone' field to MX and SRV record types

Aish-sp · Mar 27, 2023 · 8624a4a · 8624a4a
1 parent b0c55f5
commit 8624a4a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/objects.go b/objects.go
@@ -803,24 +803,27 @@ type RecordMX struct {
 	Fqdn       string `json:"name,omitempty"`
 	MX         string `json:"mail_exchanger,omitempty"`
 	Preference uint32 `json:"preference"`
+	Zone       string `json:"zone,omitempty"`
 	Ttl        uint32 `json:"ttl"`
 	UseTtl     bool   `json:"use_ttl"`
 	Comment    string `json:"comment"`
 	Ea         EA     `json:"extattrs"`
 }
 
+var mxRecordReturnFieldsList = []string{"mail_exchanger", "view", "name", "preference", "ttl", "use_ttl", "comment", "extattrs", "zone"}
+
 func NewEmptyRecordMX() *RecordMX {
 	res := &RecordMX{}
 	res.objectType = "record:mx"
-	res.returnFields = []string{"mail_exchanger", "view", "name", "preference", "ttl", "use_ttl", "comment", "extattrs"}
+	res.returnFields = mxRecordReturnFieldsList
 
 	return res
 }
 
 func NewRecordMX(rm RecordMX) *RecordMX {
 	res := rm
 	res.objectType = "record:mx"
-	res.returnFields = []string{"mail_exchanger", "view", "name", "preference", "ttl", "use_ttl", "comment", "extattrs"}
+	res.returnFields = mxRecordReturnFieldsList
 
 	return &res
 }
@@ -834,24 +837,27 @@ type RecordSRV struct {
 	Weight   uint32 `json:"weight"`
 	Port     uint32 `json:"port"`
 	Target   string `json:"target,omitempty"`
+	Zone     string `json:"zone,omitempty"`
 	Ttl      uint32 `json:"ttl"`
 	UseTtl   bool   `json:"use_ttl"`
 	Comment  string `json:"comment"`
 	Ea       EA     `json:"extattrs"`
 }
 
+var srvRecordReturnFieldsList = []string{"name", "view", "priority", "weight", "port", "target", "ttl", "use_ttl", "comment", "extattrs", "zone"}
+
 func NewEmptyRecordSRV() *RecordSRV {
 	res := RecordSRV{}
 	res.objectType = "record:srv"
-	res.returnFields = []string{"name", "view", "priority", "weight", "port", "target", "ttl", "use_ttl", "comment", "extattrs"}
+	res.returnFields = srvRecordReturnFieldsList
 
 	return &res
 }
 
 func NewRecordSRV(rv RecordSRV) *RecordSRV {
 	res := rv
 	res.objectType = "record:srv"
-	res.returnFields = []string{"name", "view", "priority", "weight", "port", "target", "ttl", "use_ttl", "comment", "extattrs"}
+	res.returnFields = srvRecordReturnFieldsList
 
 	return &res
 }

diff --git a/objects_test.go b/objects_test.go
@@ -638,7 +638,7 @@ var _ = Describe("Objects", func() {
 
 			It("should set base fields correctly", func() {
 				Expect(rm.ObjectType()).To(Equal("record:mx"))
-				Expect(rm.ReturnFields()).To(ConsistOf("mail_exchanger", "view", "name", "preference", "ttl", "use_ttl", "comment", "extattrs"))
+				Expect(rm.ReturnFields()).To(ConsistOf("mail_exchanger", "view", "name", "preference", "ttl", "use_ttl", "comment", "extattrs", "zone"))
 			})
 		})
 
@@ -681,7 +681,7 @@ var _ = Describe("Objects", func() {
 			})
 			It("should set base fields correctly", func() {
 				Expect(rv.ObjectType()).To(Equal("record:srv"))
-				Expect(rv.ReturnFields()).To(ConsistOf("name", "view", "priority", "weight", "port", "target", "ttl", "use_ttl", "comment", "extattrs"))
+				Expect(rv.ReturnFields()).To(ConsistOf("name", "view", "priority", "weight", "port", "target", "ttl", "use_ttl", "comment", "extattrs", "zone"))
 			})
 
 		})