adding one more search criterion for getting MX-record

Aish-sp · Mar 21, 2023 · b0c55f5 · b0c55f5
1 parent 6775107
commit b0c55f5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/object_manager.go b/object_manager.go
@@ -56,7 +56,7 @@ type IBObjectManager interface {
 	SearchHostRecordByAltId(internalId string, ref string, eaNameForInternalId string) (*HostRecord, error)
 	GetHostRecordByRef(ref string) (*HostRecord, error)
 	GetIpAddressFromHostRecord(host HostRecord) (string, error)
-	GetMXRecord(dnsView string, fqdn string, mx string) (*RecordMX, error)
+	GetMXRecord(dnsView string, fqdn string, mx string, preference uint32) (*RecordMX, error)
 	GetMXRecordByRef(ref string) (*RecordMX, error)
 	GetNetwork(netview string, cidr string, isIPv6 bool, ea EA) (*Network, error)
 	GetNetworkByRef(ref string) (*Network, error)

diff --git a/object_manager_mx_record.go b/object_manager_mx_record.go
@@ -50,7 +50,7 @@ func (objMgr *ObjectManager) GetMXRecordByRef(ref string) (*RecordMX, error) {
 	return recordMX, err
 }
 
-func (objMgr *ObjectManager) GetMXRecord(dnsView string, fqdn string, mx string) (*RecordMX, error) {
+func (objMgr *ObjectManager) GetMXRecord(dnsView string, fqdn string, mx string, preference uint32) (*RecordMX, error) {
 	if dnsView == "" || fqdn == "" {
 		return nil, fmt.Errorf("'DNS view' and 'fqdn' are required to retrieve a unique mx record")
 	}
@@ -61,6 +61,7 @@ func (objMgr *ObjectManager) GetMXRecord(dnsView string, fqdn string, mx string)
 		"view":           dnsView,
 		"name":           fqdn,
 		"mail_exchanger": mx,
+		"preference":     fmt.Sprintf("%d", preference),
 	}
 	queryParams := NewQueryParams(false, sf)
 	err := objMgr.connector.GetObject(recordMX, "", queryParams, &res)

diff --git a/object_manager_mx_record_test.go b/object_manager_mx_record_test.go
@@ -179,6 +179,7 @@ var _ = Describe("Object Manager: MX-record", func() {
 			"view":           dnsView,
 			"name":           fqdn,
 			"mail_exchanger": mx,
+			"preference":     fmt.Sprintf("%d", preference),
 		}
 		nwFakeConnector := &fakeConnector{
 			getObjectObj:         NewEmptyRecordMX(),
@@ -202,7 +203,7 @@ var _ = Describe("Object Manager: MX-record", func() {
 		var actualRecord *RecordMX
 		var err error
 		It("should pass expected MX record object to GetObject", func() {
-			actualRecord, err = objMgr.GetMXRecord(dnsView, fqdn, mx)
+			actualRecord, err = objMgr.GetMXRecord(dnsView, fqdn, mx, preference)
 		})
 		It("should return expected MX record Object", func() {
 			Expect(actualRecord).NotTo(BeNil())