wallet misc #6191
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,54 @@ | ||
| #!/bin/sh | ||
|
|
||
| if [ -z "$AGORIC_NET" ]; then | ||
| echo "AGORIC_NET env not set" | ||
| echo | ||
| echo "e.g. AGORIC_NET=ollinet (or export to save typing it each time)" | ||
| echo | ||
| echo "To test locally, AGORIC_NET=local and have the following running: | ||
| # freshen sdk | ||
| cd agoric-sdk | ||
| yarn install && yarn build | ||
|
|
||
| # (new tab) | ||
| # Start the chain | ||
| cd packages/cosmic-swingset | ||
| make scenario2-setup scenario2-run-chain-psm | ||
|
|
||
| # (new tab) | ||
| # Fund the pool (addr is a magic string) | ||
| make SOLO_COINS=1234000000ibc/usdc1234 ACCT_ADDR=agoric1megzytg65cyrgzs6fvzxgrcqvwwl7ugpt62346 fund-acct | ||
| # Provision your wallet | ||
| cd packages/cosmic-swingset | ||
| # Copy the agoric address from your keplr wallet or 'agd keys list', starts with 'agoric1' | ||
| WALLET_ADDR=<yours> | ||
| make ACCT_ADDR=$WALLET_ADDR AGORIC_POWERS=SMART_WALLET fund-acct provision-acct | ||
| # verify | ||
| agoric wallet list | ||
| agoric wallet show --from $WALLET_ADDR | ||
| " | ||
| exit 1 | ||
| fi | ||
|
|
||
| KEY=$1 | ||
|
|
||
| if [ -z "$KEY" ]; then | ||
| echo "USAGE: $0 key" | ||
| echo "You can reference by name: agd keys list" | ||
| echo "Make sure it has been provisioned by the faucet: https://$AGORIC_NET.faucet.agoric.net/" | ||
| exit 1 | ||
| fi | ||
|
|
||
| set -x | ||
|
|
||
| # NB: fee percentages must be at least the governed param values | ||
|
|
||
| # perf test wantMinted | ||
| OFFER=$(mktemp -t agops.XXX) | ||
| bin/agops psm swap --wantMinted 0.01 --feePct 0.01 >|"$OFFER" | ||
| time bin/agops perf satisfaction --executeOffer "$OFFER" --from "$KEY" | ||
|
|
||
| # perf test giveMinted | ||
| OFFER=$(mktemp -t agops.XXX) | ||
| bin/agops psm swap --giveMinted 0.01 --feePct 0.03 >|"$OFFER" | ||
| time bin/agops perf satisfaction --executeOffer "$OFFER" --from "$KEY" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| #! /usr/bin/env node | ||
| import '@endo/init'; | ||
| import { createBundles } from '@agoric/deploy-script-support'; | ||
| import url from 'url'; | ||
|
|
||
| const dirname = url.fileURLToPath(new URL('.', import.meta.url)); | ||
|
|
||
| const sourceToBundle = [ | ||
| [ | ||
| `@agoric/smart-wallet/src/walletFactory.js`, | ||
| `../bundles/bundle-walletFactory.js`, | ||
| ], | ||
| ]; | ||
|
|
||
| await createBundles(sourceToBundle, dirname); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -343,7 +343,9 @@ const behavior = { | |
| */ | ||
| async executeOffer(offerSpec) { | ||
| const { facets, state } = this; | ||
| /** @type {State} */ | ||
| const { | ||
| address, | ||
|
There was a problem hiding this comment. hm. I missed something somewhere. A wallet knows the address it's associated with? Is that necessary? It sets off my ACL spidey-sense... it feels vagely like caller or There was a problem hiding this comment. Yeah, I had the same tingle. It's not strictly necessary. We could take it out by passing two other things in instead:
But it has to persist through init and there may be some churn with durability, so I'll punt until then: #5894 |
||
| zoe, | ||
| brandPurses, | ||
| invitationBrand, | ||
|
|
@@ -353,6 +355,11 @@ const behavior = { | |
| updatePublishKit, | ||
| } = this.state; | ||
|
|
||
| const logger = { | ||
| info: (...args) => console.info('wallet', address, ...args), | ||
| error: (...args) => console.log('wallet', address, ...args), | ||
| }; | ||
|
|
||
| const executor = makeOfferExecutor({ | ||
| zoe, | ||
| depositFacet: facets.deposit, | ||
|
|
@@ -375,12 +382,15 @@ const behavior = { | |
| state.lastOfferId = id; | ||
| }, | ||
| }, | ||
| logger, | ||
| }, | ||
| onStatusChange: offerStatus => { | ||
| logger.info('offerStatus', offerStatus); | ||
| updatePublishKit.publisher.publish({ | ||
| updated: 'offerStatus', | ||
| status: offerStatus, | ||
| }); | ||
| }, | ||
| onNewContinuingOffer: (offerId, invitationMakers) => | ||
| offerToInvitationMakers.init(offerId, invitationMakers), | ||
| }); | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 ocap-happy logging