wallet misc #6191
Merged
wallet misc #6191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
added
automerge:no-update
dckc
approved these changes
Sep 13, 2022
| @@ -43,7 +44,7 @@ export const makeOfferExecutor = ({ | |||
| onStatusChange, | |||
| onNewContinuingOffer, | |||
| }) => { | |||
| const { invitationFromSpec, lastOfferId, purseForBrand } = powers; | |||
| const { invitationFromSpec, lastOfferId, logger, purseForBrand } = powers; | |||
| const { | ||
| address, |
There was a problem hiding this comment.
hm. I missed something somewhere. A wallet knows the address it's associated with? Is that necessary? It sets off my ACL spidey-sense... it feels vagely like caller or msg.sender in solidity.
There was a problem hiding this comment.
Yeah, I had the same tingle. It's not strictly necessary. We could take it out by passing two other things in instead:
- wallet logger
- wallet storageNode
But it has to persist through init and there may be some churn with durability, so I'll punt until then: #5894
| numWantsSatisfied: numSatisfied, | ||
| }); | ||
| }, | ||
| handleError, |
There was a problem hiding this comment.
The commit message doesn't mention this. (not critical)
turadg
added
automerge:no-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Security Considerations
Stops publishing offerResult for copyRecord. Publishes simple types.
Documentation Considerations
--
Testing Considerations
--