-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PW-562 Add applicationInformation into PHP API library #77
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0905507
- Adding filterParameters in the resources where you can define if there
06897b8
Add boolean check if applicationInfo is necessary ot not in the request
1407fb2
Set allow to default false based on code review
69dc7af
Add Client public setter functions for applicationInfo properties
91d6e43
Remove allow ApplicaionInfo from payment details and payment result
1d067ce
Add integrator as a possible parameter in the
27cfe43
remove topLevelKey from test params since we don't use it anymore
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,12 +4,27 @@ | |
|
||
class PaymentsDetails extends \Adyen\Service\AbstractCheckoutResource | ||
{ | ||
protected $_endpoint; | ||
/** | ||
* @var string | ||
*/ | ||
protected $_endpoint; | ||
|
||
/** | ||
* Include applicationInfo key in the request parameters | ||
* | ||
* @var bool | ||
*/ | ||
protected $allowApplicationInfo = true; | ||
|
||
/** | ||
* PaymentsDetails constructor. | ||
* | ||
* @param \Adyen\Service $service | ||
* @throws \Adyen\AdyenException | ||
*/ | ||
public function __construct($service) | ||
{ | ||
$this->_endpoint = $this->getCheckoutEndpoint($service) .'/'. $service->getClient()->getApiCheckoutVersion() . '/payments/details'; | ||
parent::__construct($service, $this->_endpoint); | ||
parent::__construct($service, $this->_endpoint, $this->allowApplicationInfo); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this can be false as this endpoint does not support it. |
||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,12 +4,27 @@ | |
|
||
class PaymentsResult extends \Adyen\Service\AbstractCheckoutResource | ||
{ | ||
protected $_endpoint; | ||
/** | ||
* @var string | ||
*/ | ||
protected $_endpoint; | ||
|
||
/** | ||
* Include applicationInfo key in the request parameters | ||
* | ||
* @var bool | ||
*/ | ||
protected $allowApplicationInfo = true; | ||
|
||
/** | ||
* PaymentsResult constructor. | ||
* | ||
* @param \Adyen\Service $service | ||
* @throws \Adyen\AdyenException | ||
*/ | ||
public function __construct($service) | ||
{ | ||
$this->_endpoint = $this->getCheckoutEndpoint($service) .'/'. $service->getClient()->getApiCheckoutVersion() . '/payments/result'; | ||
parent::__construct($service, $this->_endpoint); | ||
parent::__construct($service, $this->_endpoint, $this->allowApplicationInfo); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this can be false as this endpoint does not support it. |
||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
externalPlatform has three fields. I am seeing integrator field is missing. Is this intentional ?