PW-562 Add applicationInformation into PHP API library #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is any parameter in the request which you don't want to send towards the specified API endpoint - PHP Doc blocks added - Unit tests added
If the applicationInfo should be in the request then fill the default data
|
Hi @cyattilakiss, I would do it the opposite way so if a new resources are added it is by default not used. So allowApplicationInfo = true on the resource where we allow it and on the AbstractResource put the default on false. Regards, |
added 2 commits
October 11, 2018 14:17
rikterbeek
reviewed
Oct 12, 2018
| public function __construct($service) | ||
| { | ||
| $this->_endpoint = $this->getCheckoutEndpoint($service) .'/'. $service->getClient()->getApiCheckoutVersion() . '/payments/details'; | ||
| parent::__construct($service, $this->_endpoint); | ||
| parent::__construct($service, $this->_endpoint, $this->allowApplicationInfo); |
There was a problem hiding this comment.
this can be false as this endpoint does not support it.
| public function __construct($service) | ||
| { | ||
| $this->_endpoint = $this->getCheckoutEndpoint($service) .'/'. $service->getClient()->getApiCheckoutVersion() . '/payments/result'; | ||
| parent::__construct($service, $this->_endpoint); | ||
| parent::__construct($service, $this->_endpoint, $this->allowApplicationInfo); |
There was a problem hiding this comment.
this can be false as this endpoint does not support it.
rkewlani
reviewed
Oct 12, 2018
src/Adyen/Client.php
Outdated
| */ | ||
| public function setExternalPlatform($name, $version) | ||
| { | ||
| $this->_config->set('externalPlatform', array('name' => $name, 'version' => $version)); |
There was a problem hiding this comment.
externalPlatform has three fields. I am seeing integrator field is missing. Is this intentional ?
applicationInfo.externalPlatform Unit tests added
rkewlani
approved these changes
Oct 12, 2018
Aleffio
approved these changes
Oct 12, 2018
rikterbeek
approved these changes
Oct 13, 2018
lancergr
reviewed
Oct 15, 2018
tests/Unit/AbstractResourceTest.php
Outdated
| public function testHandleApplicationInfoInRequestShouldRemoveApplicationInfoFromParams() | ||
| { | ||
| $params = array( | ||
| "topLevelKey" => "test", |
There was a problem hiding this comment.
as discussed, shall we better remove the "topLevelKey" since we don't use it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding filterParameters in the resources where you can define if there
is any parameter in the request which you don't want to send towards the
specified API endpoint
Tested scenarios
Unit tests added