Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3128 - Redirect Manager import from xlsx not working #3129

Conversation

lollegp
Copy link
Contributor

@lollegp lollegp commented Jul 6, 2023

(#3128)

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #3129 (2fab221) into master (3698e61) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 2fab221 differs from pull request most recent head 94846fe. Consider uploading reports for the commit 94846fe to get more accurate results

@@            Coverage Diff            @@
##             master    #3129   +/-   ##
=========================================
  Coverage     55.18%   55.18%           
+ Complexity     5405     5404    -1     
=========================================
  Files           711      711           
  Lines         28988    28988           
  Branches       3745     3745           
=========================================
  Hits          15997    15997           
  Misses        11488    11488           
  Partials       1503     1503           
Impacted Files Coverage Δ
...mmons/mcp/impl/ProcessErrorReportExcelServlet.java 100.00% <100.00%> (ø)

@YegorKozlov
Copy link
Contributor

Thanks for the PR. This class was impacted by the POI version upgrade, but it's not used by redirect manager.

The classes to fix are com/adobe/acs/commons/redirects/servlets/ExportRedirectMapServlet.java and com.adobe.acs.commons.redirects.servlets.ImportRedirectMapServlet

…s not available anymore in new version of the dependencies
@lollegp
Copy link
Contributor Author

lollegp commented Jul 7, 2023

Thanks, you are right, I add the fix in the right files and also in another one spotted in the GenericReportServlet.

Copy link
Contributor

@YegorKozlov YegorKozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidjgonzalez davidjgonzalez merged commit e3cf05e into Adobe-Consulting-Services:master Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants