Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect Manager - Import from excel not working due to "Apache Poi" dependencies upgrade #3128

Closed
3 tasks done
lollegp opened this issue Jul 6, 2023 · 4 comments
Closed
3 tasks done
Assignees
Labels
Milestone

Comments

@lollegp
Copy link
Contributor

lollegp commented Jul 6, 2023

Required Information

  • AEM Version: AEM Cloud SDK 2023.6.12255.20230608T053118Z
  • ACS AEM Commons Version: 6.0.10
  • Reproducible on Latest? yes

Expected Behavior

In redirect manager I should be able to import a set of redirect from an excel file

Actual Behavior

In redirect manager when I try to import a set of redirect from an excel file I'm getting 500 with an exception and can't proceed with the import

Steps to Reproduce

Tools --> ACS AEM Commons --> Manage Redirects --> Choose one conf (not relevant which one) --> Import --> Upload xlsx file (even if you upload an empty one is not working) --> Import Redirect Map --> FAIL

Links

Screenshot 2023-07-06 at 18 57 51
@lollegp
Copy link
Contributor Author

lollegp commented Jul 6, 2023

After a quick analysis it seems that with the new AEM Cloud SDK the "Apache Poi" bundle has been updated and in the new version all deprecated methods have been removed and should be replaced with some new available methods.

lollegp added a commit to lollegp/acs-aem-commons that referenced this issue Jul 6, 2023
lollegp added a commit to lollegp/acs-aem-commons that referenced this issue Jul 6, 2023
@YegorKozlov YegorKozlov self-assigned this Jul 7, 2023
@YegorKozlov
Copy link
Contributor

I confirmed the issue with aem-sdk-2023.6.12441.20230623T133322Z and AEM 6.5.17

ACS commons does not control the version of Apache POI - Apache POI is a transitive dependency of Apache Tika which is used internally by Jackrabbit to index binary data.

It appears the POI version has been upgraded from 4.0.1 to 5.2.3 which is quite a leap. And it impacted every place where we read data from spreadsheets: Redirect Manager, MCP jobs, reports, etc .

The minimal version of AEM supported by ACS Commons is 6.5.10, which means we need to support both versions: v4.0.1 and v5.2.3.

@lollegp
Copy link
Contributor Author

lollegp commented Jul 7, 2023

Thanks, Here the PR #3129 to fix the issue for Redirect Manager. It is a simple replacement of the deprecated method with an alternative one. The methods were already deprecated in v 4.0.1 so it should be retro-compatible.

lollegp added a commit to lollegp/acs-aem-commons that referenced this issue Jul 7, 2023
…s not available anymore in new version of the dependencies
davidjgonzalez pushed a commit that referenced this issue Jul 7, 2023
* #3128 - Redirect Manager import from xlsx not working due to apache poi bundle upgrade in cloud SDK (#3128)

* #3128 - Update CHANGELOG.md

* #3128 - replace deprecated apache.poi methods not available anymore in new version of the dependencies
@davidjgonzalez
Copy link
Contributor

Fixed in 6.0.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants