Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with proxied clientlib #2581

Conversation

pcastelog
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented May 3, 2021

Pull Request Test Coverage Report for Build 6408

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 56.471%

Totals Coverage Status
Change from base Build 6396: 0.002%
Covered Lines: 16681
Relevant Lines: 29539

💛 - Coveralls

@kwin
Copy link
Contributor

kwin commented May 4, 2021

@pcastelog Thanks for the PR. Can you add a changelog entry and a test for this?

@henrykuijpers
Copy link
Contributor

@kwin I think it is very important to get this issue pushed in very quickly. The entire functionality is broken now (for us, mainly on author, since we have no /etc/map entries there).

@pcastelog
Copy link
Contributor Author

I added the requested changes

  • Test for the case of resolving a clientlib with resourceResolver
  • Changelog

CHANGELOG.md Outdated Show resolved Hide resolved
@kwin kwin merged commit 9f6c158 into Adobe-Consulting-Services:master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants