Versioned ClientLibs no longer works as of 4.12.0

[cshawaus]

AEM Version: 6.5.7
ACS AEM Commons Version: 4.12.0+
Reproducible on Latest? yes

Expected Behavior

Proxied ClientLib paths should correctly output paths with a hash. This works correctly in ACS Commons v4.11.2 and below.

Actual Behavior

As a result of #2528, this behaviour has completely regressed and Versioned ClientLibs no longer generates hashes for proxied ClientLib paths.

Based on my observations, the following is preventing the resolvePath method from succeeding as libraryResource always resolves to /etc.

acs-aem-commons/bundle/src/main/java/com/adobe/acs/commons/rewriter/impl/VersionedClientlibsTransformerFactory.java

Lines 242 to 248 in 84fcdd4

	String libraryPath = StringUtils.substringBeforeLast(originalPath, ".");
	if (libraryPath.endsWith(MIN_SELECTOR_SEGMENT)) {
	appendMinSelector = true;
	libraryPath = StringUtils.substringBeforeLast(libraryPath, ".");
	}
	final HtmlLibrary htmlLibrary = getLibrary(libraryType, libraryPath, request);

acs-aem-commons/bundle/src/main/java/com/adobe/acs/commons/rewriter/impl/VersionedClientlibsTransformerFactory.java

Lines 282 to 288 in 84fcdd4

	private String resolvePath(LibraryType libraryType, String libraryPath, SlingHttpServletRequest request) {
	Resource libraryResource = request.getResourceResolver().resolve(request, libraryPath);
	if (libraryResource != null && !(libraryResource instanceof NonExistingResource)) {
	return libraryResource.getPath();
	}
	return resolvePathIfProxied(libraryType, libraryPath, request.getResourceResolver());
	}

Steps to Reproduce

1. Create a new ClientLib in /apps/<project> with an empty stylesheet
2. Set allowProxy to {Boolean}true
3. Add the new ClientLib to your page template
4. Ensure the versioned-clientlib rewriter exists at /system/console/status-slingrewriter
5. Observe no hashes been added

Links

#2533

[kwin]

There is a comment in #2577 (comment) which might be helpful. @pcastelog WDYT? Can you come up with a bugfix?

[pcastelog]

Agree with @cshawaus . I think the best option here will be to check if the path starts with "/etc.clientlibs". I will provide a fix asap.

[pcastelog]

#2581

[kwin]

This is fixed by #2581