Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve ClientLib before trying to get it with the HtmlLibraryManager #2533

Merged
merged 3 commits into from
Feb 22, 2021
Merged

Resolve ClientLib before trying to get it with the HtmlLibraryManager #2533

merged 3 commits into from
Feb 22, 2021

Conversation

pcastelog
Copy link
Contributor

@pcastelog pcastelog commented Feb 20, 2021 •
edited by davidjgonzalez
Loading

Resolves #2528

@pcastelog pcastelog mentioned this pull request Feb 20, 2021
Closed
3 tasks
@coveralls
Copy link

coveralls commented Feb 20, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 6292

  • 8 of 9 (88.89%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 55.648%
Changes Missing Coverage Covered Lines Changed/Added Lines %
bundle/src/main/java/com/adobe/acs/commons/rewriter/impl/VersionedClientlibsTransformerFactory.java 8 9 88.89%
Totals Coverage Status
Change from base Build 6289: 0.003%
Covered Lines: 16040
Relevant Lines: 28824
💛 - Coveralls

kwin
kwin requested changes Feb 21, 2021
View reviewed changes
Copy link
Contributor

@kwin kwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I added some remarks.

...src/main/java/com/adobe/acs/commons/rewriter/impl/VersionedClientlibsTransformerFactory.java Outdated Show resolved Hide resolved
...src/main/java/com/adobe/acs/commons/rewriter/impl/VersionedClientlibsTransformerFactory.java Outdated Show resolved Hide resolved
pcastelog and others added 2 commits February 21, 2021 21:21
@pcastelog
Update VersionedClientlibsTransformerFactory.java
758c0f6 
Merge resolvePath and resolvePathIfJcrMapping in one method. Move the request to the new method to resolve the URL with request and path parameters
@davidjgonzalez
Merge branch 'master' into defect/versioned-clientlibs/clientlib-jcr-…
63900a1 
…mapping-not-resolved
@davidjgonzalez davidjgonzalez self-requested a review February 21, 2021 21:17
@davidjgonzalez davidjgonzalez merged commit bd1438a into Adobe-Consulting-Services:master Feb 22, 2021
@davidjgonzalez davidjgonzalez added this to the 4.12.0 milestone Feb 22, 2021
id-keenan added a commit to id-keenan/acs-aem-commons that referenced this pull request Feb 22, 2021
@id-keenan
Merge branch 'master' into feature/templated-dialogs
a7aff12 
* master:
  Feature/dispatcher max age filter based on resource type (Adobe-Consulting-Services#2511)
  Resolve ClientLib before trying to get it with the HtmlLibraryManager (Adobe-Consulting-Services#2533)
  Make serialization of JWT succeed (called due to calling compact) (Adobe-Consulting-Services#2530)
  make RobotsServletTest succeed on Windows (where server emits \r\n line (Adobe-Consulting-Services#2516)

# Conflicts:
#	CHANGELOG.md
@kwin kwin removed this from the 4.12.0 milestone Mar 3, 2021
@cshawaus cshawaus mentioned this pull request Apr 2, 2021
Closed
@YegorKozlov YegorKozlov mentioned this pull request Apr 27, 2021
Closed
3 tasks
@kwin kwin mentioned this pull request May 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwin kwin kwin approved these changes

@davidjgonzalez davidjgonzalez davidjgonzalez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Versioned ClientLibs not working with Resource Resolver Mapping
4 participants
@pcastelog @coveralls @kwin @davidjgonzalez