Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce marker interface for ClusterLeader #2499

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Dec 21, 2020

Automatically generate service of that type.
Leverage from JcrPackageReplicationStatusEventHandler and
TwitterFeedScheduler.

This closes #2492 #2498

Automatically generate service of that type.
Leverage from JcrPackageReplicationStatusEventHandler and
TwitterFeedScheduler.

This closes Adobe-Consulting-Services#2492 Adobe-Consulting-Services#2498
@coveralls
Copy link

coveralls commented Feb 21, 2021

Pull Request Test Coverage Report for Build 6293

  • 13 of 36 (36.11%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 55.601%

Changes Missing Coverage Covered Lines Changed/Added Lines %
bundle/src/main/java/com/adobe/acs/commons/replication/status/impl/JcrPackageReplicationStatusEventHandler.java 12 15 80.0%
bundle/src/main/java/com/adobe/acs/commons/util/impl/DiscoveryServiceHelper.java 0 20 0.0%
Totals Coverage Status
Change from base Build 6289: -0.04%
Covered Lines: 16033
Relevant Lines: 28836

💛 - Coveralls

@davidjgonzalez
Copy link
Contributor

@kwin there are 2 files w Netcentric headers in this.

Are these headers here because they were originally released under this license and they're copy/paste to this project? IIUC if did copy/paste into this project you'd have to retain the attribution to the original project, though I'm not sure if it would need to have both licenses? .. clearly IANAL

@kwin
Copy link
Contributor Author

kwin commented Feb 21, 2021

This is not about the license (ASL 2.0) but only about the copyright. If you insist on donating the copyright to Adobe that may be ok if

  • a reasoning is given and
  • this is clarified in the contributors guidelines

@kwin kwin merged commit ddd20a2 into Adobe-Consulting-Services:master Mar 3, 2021
id-keenan added a commit to id-keenan/acs-aem-commons that referenced this pull request Mar 15, 2021
* master:
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release acs-aem-commons-5.0.2
  v5.0.2 release
  Don't set ACLs on potentially non-existing path /etc/tags (Adobe-Consulting-Services#2547)
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release acs-aem-commons-5.0.0
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release acs-aem-commons-4.12.0
  4.12.0 changelog
  Sorter (Update) (Adobe-Consulting-Services#2544)
  Adobe-Consulting-Services#2542 - Fixed VanityUrlAdjuster package location (Adobe-Consulting-Services#2543)
  ACS Redirect Manager (Adobe-Consulting-Services#2513)
  Adding (backwards compatible) options to the i18nprovider / injector to: (Adobe-Consulting-Services#2518)
  Add append option to dataimporter (Adobe-Consulting-Services#2535)
  Make sure show hide of tabs also works when coral panel is of region (Adobe-Consulting-Services#2540)
  Make ui.content package no longer block replication queue on AEMaaCS (Adobe-Consulting-Services#2523)
  Introduce marker interface for ClusterLeader (Adobe-Consulting-Services#2499)

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE in JcrPackageReplicationStatusEventHandler
3 participants