Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to consume "VanityUrlAdjuster" in custom application #2542

Closed
abhinavsinha347 opened this issue Mar 11, 2021 · 13 comments
Closed

Unable to consume "VanityUrlAdjuster" in custom application #2542

abhinavsinha347 opened this issue Mar 11, 2021 · 13 comments
Assignees
@davidjgonzalez
Labels
bug
Milestone
5.0.4

Comments

@abhinavsinha347
Copy link
Contributor

Required Information

  • AEM version : 6.5.7
  • ACS Commons version: 4.11.2
  • Reproducible on Latest? yes

Expected Behavior

Able to consume VanityUrlAdjuster Interface to provide custom implementations as per the documentation.

Actual Behavior

Unable to consume the Interface as its not exported.

Steps to Reproduce

Create a service class in custom application and write an implementation of VanityUrlAdjuster. Deploy the bundle to AEM and check bundle status.

Screenshot 2021-03-11 at 12 06 29
@abhinavsinha347
Copy link
Contributor Author

@davidjgonzalez Can you please review this bug ? Its broken in this PR
#2351

davidjgonzalez added a commit to davidjgonzalez/acs-aem-commons that referenced this issue Mar 13, 2021
@davidjgonzalez
Adobe-Consulting-Services#2542 - Fixed VanityUrlAdjuster package loca…
e142728 
…tion
davidjgonzalez added a commit that referenced this issue Mar 13, 2021
@davidjgonzalez
#2542 - Fixed VanityUrlAdjuster package location (#2543)
e049f0c
@davidjgonzalez
Copy link
Contributor

Fixed in v4.12.0

@davidjgonzalez davidjgonzalez added this to the 4.12.0 milestone Mar 13, 2021
@davidjgonzalez davidjgonzalez self-assigned this Mar 13, 2021
@davidjgonzalez
Copy link
Contributor

Yesterday, should be available on maven central now. Just didn't have time to update the website!

@abhinavsinha347
Copy link
Contributor Author

Thanks @davidjgonzalez , can someone please test this as the custom Impl class that i have written is not being called. And this is a very critical feature for our go live, unless a fix is required and we end up rewriting VanityURLServiceImpl in our code base.

Appreciate your help here :)

@davidjgonzalez
Copy link
Contributor

Sorry, don't understand the ask. Only you has your customer class to test..?

@abhinavsinha347
Copy link
Contributor Author

So, i was trying to write the Impl for Adjuster class, but for some reason in "VanityURLServiceImpl" the vanityUrlAdjuster variable is always null. May be i am doing something wrong or something wrong on ACS commons end.

@davidjgonzalez
Copy link
Contributor

Have you tried compiling against 4.12.0 w the VanityUrlAdjuster interface in the updated (Public) location?

id-keenan added a commit to id-keenan/acs-aem-commons that referenced this issue Mar 15, 2021
@id-keenan
Merge branch 'master' into feature/templated-dialogs
2b857e5 
* master:
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release acs-aem-commons-5.0.2
  v5.0.2 release
  Don't set ACLs on potentially non-existing path /etc/tags (Adobe-Consulting-Services#2547)
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release acs-aem-commons-5.0.0
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release acs-aem-commons-4.12.0
  4.12.0 changelog
  Sorter (Update) (Adobe-Consulting-Services#2544)
  Adobe-Consulting-Services#2542 - Fixed VanityUrlAdjuster package location (Adobe-Consulting-Services#2543)
  ACS Redirect Manager (Adobe-Consulting-Services#2513)
  Adding (backwards compatible) options to the i18nprovider / injector to: (Adobe-Consulting-Services#2518)
  Add append option to dataimporter (Adobe-Consulting-Services#2535)
  Make sure show hide of tabs also works when coral panel is of region (Adobe-Consulting-Services#2540)
  Make ui.content package no longer block replication queue on AEMaaCS (Adobe-Consulting-Services#2523)
  Introduce marker interface for ClusterLeader (Adobe-Consulting-Services#2499)

# Conflicts:
#	CHANGELOG.md
@abhinavsinha347
Copy link
Contributor Author

@davidjgonzalez #2548, need to make VanityUrlAdjuster volatile for dynamic references

@kwin kwin reopened this Mar 17, 2021
@kwin
Copy link
Contributor

kwin commented Mar 17, 2021

@abhinavsinha347 Can you come up with a PR?

@abhinavsinha347
Copy link
Contributor Author

@kwin sure.

abhinavsinha347 pushed a commit to abhinavsinha347/acs-aem-commons that referenced this issue Mar 17, 2021
Adobe-Consulting-Services#2542 : Adding change log
6871dd2
@kwin
Copy link
Contributor

kwin commented Mar 17, 2021

Should be fixed by #2552.

@kwin kwin modified the milestones: 4.12.0, 5.0.4 Mar 17, 2021
@davidjgonzalez
Copy link
Contributor

Fixed in 5.0.4 (released) - @abhinavsinha347 let me know if you need this back-ported to a 4.x.x line.

@abhinavsinha347
Copy link
Contributor Author

@davidjgonzalez , i can upgrade to 5.0.4 version that should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidjgonzalez davidjgonzalez

Labels
bug
Projects
None yet
Milestone
5.0.4
Development

No branches or pull requests
3 participants
@kwin @davidjgonzalez @abhinavsinha347