-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite the testsuite for the JCRHttpCache #2120
Merged
davidjgonzalez
merged 13 commits into
Adobe-Consulting-Services:master
from
joerghoh:feature/improve-httpcache-tests
Nov 22, 2019
Merged
Rewrite the testsuite for the JCRHttpCache #2120
davidjgonzalez
merged 13 commits into
Adobe-Consulting-Services:master
from
joerghoh:feature/improve-httpcache-tests
Nov 22, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joerghoh
commented
Nov 21, 2019
- use SlingContext instead lots of mocks.
- and fix some issues on the way
* switched to use java.util.Clock for easier expiration testing * added some missing pieces of expiration handling logic
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the CHANGELOG.md file with this pull request. |
Pull Request Test Coverage Report for Build 5211
💛 - Coveralls |
joerghoh
changed the title
Rewrite the testsuite for the JCRHttpCache
WIP: Rewrite the testsuite for the JCRHttpCache
Nov 21, 2019
joerghoh
changed the title
WIP: Rewrite the testsuite for the JCRHttpCache
Rewrite the testsuite for the JCRHttpCache
Nov 21, 2019
@niekraaijmakers WDYT? |
This was referenced Nov 21, 2019
I approve :) |
davidjgonzalez
approved these changes
Nov 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⏰
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.