Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the testsuite for the JCRHttpCache #2120

Conversation

joerghoh
Copy link
Contributor

  • use SlingContext instead lots of mocks.
  • and fix some issues on the way

@update-changelog
Copy link

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the CHANGELOG.md file with this pull request.

@coveralls
Copy link

coveralls commented Nov 21, 2019

Pull Request Test Coverage Report for Build 5211

  • 28 of 28 (100.0%) changed or added relevant lines in 4 files are covered.
  • 31 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.4%) to 55.62%

Files with Coverage Reduction New Missed Lines %
bundle/src/main/java/com/adobe/acs/commons/httpcache/store/jcr/impl/handler/EntryNodeToCacheContentHandler.java 1 86.0%
bundle/src/main/java/com/adobe/acs/commons/httpcache/store/jcr/impl/handler/EntryNodeToCacheKeyHandler.java 1 90.91%
bundle/src/main/java/com/adobe/acs/commons/httpcache/store/jcr/impl/visitor/TotalCacheSizeVisitor.java 14 0.0%
bundle/src/main/java/com/adobe/acs/commons/httpcache/store/jcr/impl/visitor/InvalidateByCacheConfigVisitor.java 15 0.0%
Totals Coverage Status
Change from base Build 5197: 0.4%
Covered Lines: 14979
Relevant Lines: 26931

💛 - Coveralls

@joerghoh joerghoh changed the title Rewrite the testsuite for the JCRHttpCache WIP: Rewrite the testsuite for the JCRHttpCache Nov 21, 2019
@joerghoh joerghoh changed the title WIP: Rewrite the testsuite for the JCRHttpCache Rewrite the testsuite for the JCRHttpCache Nov 21, 2019
@joerghoh
Copy link
Contributor Author

@niekraaijmakers WDYT?

@niekraaijmakers
Copy link
Contributor

I approve :)

Copy link
Contributor

@davidjgonzalez davidjgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidjgonzalez davidjgonzalez merged commit 9aa60a5 into Adobe-Consulting-Services:master Nov 22, 2019
@joerghoh joerghoh deleted the feature/improve-httpcache-tests branch November 22, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants