Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpCache JCR store testcases should use proper Test library #2113

Closed
joerghoh opened this issue Nov 16, 2019 · 2 comments
Closed

HttpCache JCR store testcases should use proper Test library #2113

joerghoh opened this issue Nov 16, 2019 · 2 comments

Comments

@joerghoh
Copy link
Contributor

While working on upgrading to java 11 (requires some updates to Mocking libraries as well, see #2104) I came across a lot of test failures; also the unit tests for it rely to a complex set of Mocks and Mock classes, which I personally find hard to understand and to debug.

Replacing the mocks by the use of Sling Testing Mocks (and SlingContext) would help a lot to make both the testcases more understandable and help in the migration towards support of Java 11.
@joerghoh
Copy link
Contributor Author

see #2120 for a fix.

@joerghoh
Copy link
Contributor Author

Tests have been rewritten in #2120, this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joerghoh