Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fix 1644/asset ingestor filtering #1978

Merged
merged 7 commits into from
Jul 23, 2019
Merged

Feature/fix 1644/asset ingestor filtering #1978

merged 7 commits into from
Jul 23, 2019

Conversation

cylinder-y
Copy link
Contributor

No description provided.

@cylinder-y cylinder-y force-pushed the feature/fix-1644/asset-ingestor-filtering branch from 06275da to b5f7a09 Compare July 8, 2019 12:38
@coveralls
Copy link

coveralls commented Jul 8, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 4868

  • 41 of 44 (93.18%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 54.184%
Changes Missing Coverage Covered Lines Changed/Added Lines %
bundle/src/main/java/com/adobe/acs/commons/mcp/impl/processes/asset/AssetIngestor.java 9 12 75.0%
Totals Coverage Status
Change from base Build 4866: 0.06%
Covered Lines: 14213
Relevant Lines: 26231
💛 - Coveralls

@cylinder-y
Copy link
Contributor Author

Hi @badvision, could you please take a look and make a code review?
PR for documentation: Adobe-Consulting-Services/adobe-consulting-services.github.io#167

@cylinder-y cylinder-y marked this pull request as ready for review July 11, 2019 14:16
@cylinder-y cylinder-y mentioned this pull request Jul 11, 2019
Closed
badvision
badvision approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@badvision badvision left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic idea! Sorry for the delay in reviewing it. Been busy over here!

@badvision badvision merged commit 2212c0d into Adobe-Consulting-Services:master Jul 23, 2019
@badvision badvision added this to the 4.2.4 milestone Jul 23, 2019
@badvision badvision modified the milestones: 4.2.4, 4.3.0 Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badvision badvision badvision approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cylinder-y @coveralls @badvision