Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset Ingestor | Add include section #1644

Closed
cylinder-y opened this issue Dec 21, 2018 · 7 comments
Closed

Asset Ingestor | Add include section #1644

cylinder-y opened this issue Dec 21, 2018 · 7 comments

Comments

@cylinder-y
Copy link
Contributor

Currently user is able to exclude some specific folders, files, extensions that would be ignored during assets import:
image

What if user is not able to analyze source content because it is too large? It is much better to provide what user wants to import.

In our case we have large filesystem with different content : video, text files and etc. We need to iterate over all file system and import only images. In this case I want to configure specific extensions to be migrated.

I guess it would be useful to have include configuration for files, folder and extensions.

I see two possible options:

  1. Add additional 3 field with Inlcude label
  2. Change behavior of the Exclude section, because currently Ingestor tools have too much configuration fields.

For the second option we could rename Exclude section to the Filter section and use the following processing logic:

  • If we want to include file, folder or extension we just write it into fields
  • If we want to exclude file, folder, or extension we will write it with minus sign '-' into field:

image

Also exclude logic should have priority over include logic

What do you think?

@badvision
Copy link
Contributor

I think it sounds fantastic, we just need to make sure to update the docs so people understand it and also change the defaults so the behavior still works the same if they leave the values unchanged. I like the way you're going about this. Admittedly when I wrote the exclude stuff it's because my sample size was small -- about 30 gb of vacation and family photos. 😄 Obviously you're working with a much larger sample size to validate the requirements of this one.

@cylinder-y
Copy link
Contributor Author

HI @badvision,

What solution is more suitable from your point of view?

  1. Add new fields
  2. Change existing fields

@badvision
Copy link
Contributor

Change existing fields I think.
It is possible to use the "multifield" component if you want 1:many entries instead of comma-delimited values. I haven't tried it with the mcp forms but I am not opposed to fixing it if it doesn't work yet.

@stale
Copy link

stale bot commented Mar 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 19, 2019
@cylinder-y
Copy link
Contributor Author

stale, do not close it, please

@stale stale bot removed the wontfix label Mar 19, 2019
@stale
Copy link

stale bot commented May 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 18, 2019
@stale stale bot removed the wontfix label May 19, 2019
cylinder-y added a commit to cylinder-y/acs-aem-commons that referenced this issue Jul 5, 2019
cylinder-y added a commit to cylinder-y/acs-aem-commons that referenced this issue Jul 8, 2019
cylinder-y added a commit to cylinder-y/acs-aem-commons that referenced this issue Jul 8, 2019
cylinder-y added a commit to cylinder-y/acs-aem-commons that referenced this issue Jul 8, 2019
cylinder-y added a commit to cylinder-y/adobe-consulting-services.github.io that referenced this issue Jul 11, 2019
cylinder-y added a commit to cylinder-y/adobe-consulting-services.github.io that referenced this issue Jul 11, 2019
cylinder-y added a commit to cylinder-y/adobe-consulting-services.github.io that referenced this issue Jul 11, 2019
cylinder-y added a commit to cylinder-y/adobe-consulting-services.github.io that referenced this issue Jul 11, 2019
@cylinder-y
Copy link
Contributor Author

Hello @badvision PR is created: #1978
PR for documentation updates: Adobe-Consulting-Services/adobe-consulting-services.github.io#167

badvision pushed a commit that referenced this issue Jul 23, 2019
@badvision badvision added this to the 4.2.4 milestone Jul 23, 2019
@badvision badvision modified the milestones: 4.2.4, 4.3.0 Jul 31, 2019
davidjgonzalez pushed a commit to Adobe-Consulting-Services/adobe-consulting-services.github.io that referenced this issue Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants