Feature/dialog resource provider #1904 #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests and support for OSGi enable/disable.
…lessly; fixed class resolution bugs to scan bundles.
…-registered models
…t don't need the extra stuff (backwards compatible with using GeneratedDialog as a base class)
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the CHANGELOG.md file with this pull request. |
Pull Request Test Coverage Report for Build 4554
💛 - Coveralls |
|
Let me know if you see any other anti-patterns that need resolving @justinedelson. |
shsteimer
reviewed
May 30, 2019
bundle/src/main/java/com/adobe/acs/commons/mcp/impl/DialogResourceProviderFactoryImpl.java
Show resolved
Hide resolved
shsteimer
reviewed
May 31, 2019
bundle/src/main/java/com/adobe/acs/commons/mcp/impl/DialogResourceProviderFactoryImpl.java
Show resolved
Hide resolved
|
@shsteimer, let me know if you have any other concerns otherwise I'm good to merge I think. |
id-keenan
added a commit
to id-keenan/acs-aem-commons
that referenced
this pull request
Jun 7, 2019
* master: Feature/dialog resource provider Adobe-Consulting-Services#1904 (Adobe-Consulting-Services#1922) Bugfix/cleanup filter xml (Adobe-Consulting-Services#1910) Update CHANGELOG.md (Adobe-Consulting-Services#1923) add javax.annotation dependency to pom as it was removed in java 11 (Adobe-Consulting-Services#1893) Feature/httpcache responseheader exclusion (Adobe-Consulting-Services#1905) Respect page inheritance in Named Transform Image Servlet for cq:Page (Adobe-Consulting-Services#1899) Allow uniform download links in JCR Compare (Adobe-Consulting-Services#1902) Feature/bugfix 1868 (Adobe-Consulting-Services#1906)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here is the dialog resource provider feature. It incorporates the disable switch suggested by @bstopp and also is more flexible with annotation support recommended by @justinedelson