Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow uniform download links in JCR Compare #1902

Merged
merged 3 commits into from
May 23, 2019
Merged

Allow uniform download links in JCR Compare #1902

merged 3 commits into from
May 23, 2019

Conversation

reggie7
Copy link
Contributor

@reggie7 reggie7 commented May 21, 2019

Fix for 1836.

@update-changelog
Copy link

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the CHANGELOG.md file with this pull request.

@coveralls
Copy link

coveralls commented May 21, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 4459

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 52.78%
Totals Coverage Status
Change from base Build 4449: 0.004%
Covered Lines: 13434
Relevant Lines: 25453
💛 - Coveralls

davidjgonzalez
davidjgonzalez approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@davidjgonzalez davidjgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @reggie7 !!!

@badvision badvision merged commit 0bd4554 into Adobe-Consulting-Services:master May 23, 2019
@badvision badvision added this to the 4.1.2 milestone May 23, 2019
id-keenan added a commit to id-keenan/acs-aem-commons that referenced this pull request Jun 7, 2019
@id-keenan
Merge branch 'master' into feature/templated-dialogs
a56017a 
* master:
  Feature/dialog resource provider Adobe-Consulting-Services#1904 (Adobe-Consulting-Services#1922)
  Bugfix/cleanup filter xml (Adobe-Consulting-Services#1910)
  Update CHANGELOG.md (Adobe-Consulting-Services#1923)
  add javax.annotation dependency to pom as it was removed in java 11 (Adobe-Consulting-Services#1893)
  Feature/httpcache responseheader exclusion (Adobe-Consulting-Services#1905)
  Respect page inheritance in Named Transform Image Servlet for cq:Page (Adobe-Consulting-Services#1899)
  Allow uniform download links in JCR Compare (Adobe-Consulting-Services#1902)
  Feature/bugfix 1868 (Adobe-Consulting-Services#1906)
@reggie7 reggie7 deleted the issues/1836-uniform-download-link-jcr-compare branch June 27, 2019 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidjgonzalez davidjgonzalez davidjgonzalez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@reggie7 @coveralls @davidjgonzalez @badvision