-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review ResourceChangeListeners #2265
Comments
If enabled JcrNodeChangeEventHandler (part of the httpcache) creates a new (Sling) job on stop/start of a Servlet. This is not necessary. |
The ConfigurationUpdateListener of the Automatic Package Replicator feature refreshes its cache also on every start/stop of a servlet, which isn't necessary. |
SystemNotificationsImpl has this property defined and does not need any change. |
fix in #2268 |
* do not listen to changes of ResourceProviders (eg. PROVIDER_ADDED, PROVIDER_REMOVED) Co-authored-by: david g <[email protected]>
commit merged, thanks! |
I came across the behavior that any ResourceChangeListener is notified when a servlet is unregistered/registered (more precise: when their corresponding ResourceProvider is unregisted/registered) if the property
resource.change.types
is not defined. This happens quite often during deployments.Depending on the implementation of the ResourceChangeListeners this can have a huge performance impact on deployments.
This issue is to validate all implementations of this service interface and check if they need to handle such (un-) registrations or if they are searching for simple resource changes in the repository.
The text was updated successfully, but these errors were encountered: