#2265 do not listen to changes of ResourceProviders (#2268)

* do not listen to changes of ResourceProviders (eg.  PROVIDER_ADDED, PROVIDER_REMOVED)

Co-authored-by: david g <[email protected]>

CHANGELOG.md

@@ -9,10 +9,14 @@ The format is based on [Keep a Changelog](http://keepachangelog.com)
 <!-- Keep this up to date! After a release, change the tag name to the latest release -->
 [unreleased changes details]: https://github.com/Adobe-Consulting-Services/acs-aem-commons/compare/acs-aem-commons-4.3.2...HEAD
 
-### Fixed
+### Added
 
+### Fixed
+- #2265 Review ResourceChangeListener configuration
 - #2187 - Upgraded oakpal.version to 2.0.0. Eliminates transitive compile dependency on oak-core-spi.
 
+### Changed
+
 ## [4.5.2] - 2020-04-18
 
 ### Added

bundle/src/main/java/com/adobe/acs/commons/httpcache/invalidator/event/JCRNodeChangeEventHandler.java

@@ -72,6 +72,9 @@
                   description = "List of paths to watch. Entries with the 'glob:' prefix are interpreted as globs, "
                           + "i.e. the * and ** wildcards are supported.",
                   name = ResourceChangeListener.PATHS),
+        @Property(label = "Type of change to listen to",
+        value = {"ADDED", "REMOVED","CHANGED"},
+        name = ResourceChangeListener.CHANGES),
         @Property(name = "webconsole.configurationFactory.nameHint",
                     value = "JCR paths to watch for changes: {" + EventConstants.EVENT_FILTER + "} "
                             + "{" + ResourceChangeListener.PATHS + "}",
@@ -103,6 +106,7 @@ protected void activate(BundleContext context, Map<String, Object> config) {
         } else {
             Dictionary<String, Object> properties = new Hashtable<>();
             properties.put(ResourceChangeListener.PATHS, config.get(ResourceChangeListener.PATHS));
+            properties.put(ResourceChangeListener.CHANGES, config.get(ResourceChangeListener.CHANGES));
             registration = context.registerService(ResourceChangeListener.class, this, properties);
         }
     }

bundle/src/main/java/com/adobe/acs/commons/replication/packages/automatic/impl/ConfigurationUpdateListener.java

@@ -64,6 +64,7 @@
 @Service(value = { ResourceChangeListener.class, AutomaticPackageReplicatorMBean.class })
 @Properties({
         @Property(name = "jmx.objectname", value = "com.adobe.acs.commons:type=Automatic Package Replicator"),
+        @Property(name=ResourceChangeListener.CHANGES, value= {"ADDED","CHANGED","REMOVED"}),
         @Property(name = ResourceChangeListener.PATHS, value = "glob:/etc/acs-commons/automatic-package-replication/**/jcr:content") })
 public class ConfigurationUpdateListener extends ResourceServiceManager
         implements ResourceChangeListener, ExternalResourceChangeListener, AutomaticPackageReplicatorMBean {