With text barista #388
Merged
With text barista #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alorma
force-pushed
the
withText_barista
branch
from
d46995b to
097b721
Compare
Sloy
reviewed
Mar 16, 2021
library/src/main/java/com/schibsted/spain/barista/internal/matcher/TextMatcher.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/com/schibsted/spain/barista/internal/matcher/TextMatcher.kt
Outdated
Show resolved
Hide resolved
| assertNotDisplayed(R.id.hintanderror_inputlayout, "Other test text") | ||
| } | ||
|
|
||
| @Test(expected = BaristaException::class) |
There was a problem hiding this comment.
You could test the exception more explicitly, to check that the error message is right.
Like this one from ListClickTest:
@Test
public void fail_whenNoViewFound() {
launchTestActivity(ListsActivity.buildIntent());
Throwable thrown = catchThrowable(() -> clickListItem(20));
spyFailureHandlerRule.assertEspressoFailures(1);
assertThat(thrown).isInstanceOf(BaristaException.class)
.hasMessage("No ListView or RecyclerView found in the hierarchy");
}
There was a problem hiding this comment.
Uhmm, it's a generic error message.. not sure if I will add a custom message here
alorma
force-pushed
the
withText_barista
branch
from
19f31f8 to
b7671d6
Compare
|
Hello! 👋 Just a kind reminder about this lovely and very useful PR 👯 |
Sloy
approved these changes
Jul 1, 2021
Sloy
pushed a commit
to DeanPike/Barista
that referenced
this pull request
Jul 5, 2021
* Create withCompatText * Move all withText(String) to withCompatText(String) * Add tests * Use custom matchers, no need to creater one * Fix tests * Fix test
Sloy
added a commit
that referenced
this pull request
Jul 5, 2021
#354) * Fix issue #283 assertDisplayedAtPosition doesn't assert displayed list view I removed the scrollListToPosition from assertDisplayedAtPosition as it is done in assertCustomAssertionAtPosition. isShowOnScreen checks to see if the view is visible to the user. getShownViewsById retuns a list of all views that match the viewId and are visible to the user. * Fix tests * With text barista (#388) * Create withCompatText * Move all withText(String) to withCompatText(String) * Add tests * Use custom matchers, no need to creater one * Fix tests * Fix test Co-authored-by: Rafa Vázquez <[email protected]> Co-authored-by: Roc Boronat <[email protected]> Co-authored-by: Bernat Borrás Paronella <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #387
As espresso uses:
class WithTextMatcher extends BoundedMatcher<View, TextView>
All asserts build on top of withText() (like assertDisplayed(), assertContains(), ...) will fail.
I've created a
withCompatTextthat checks forTextVieworTextInputLayoutin order to check it's text and does the same validations ofwithTextI cannot reuse what
withText()does, because matcherWithTextMatcherconstructor is private