Fix issue #283 assertDisplayedAtPosition doesn't assert displayed lis… #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…displayed list view I removed the scrollListToPosition from assertDisplayedAtPosition as it is done in assertCustomAssertionAtPosition. isShowOnScreen checks to see if the view is visible to the user. getShownViewsById retuns a list of all views that match the viewId and are visible to the user.
|
So sorry for the delay! I just tried it and indeed your PR fixes the issue. Thanks a lot @DeanPike! |
Sloy
approved these changes
Aug 18, 2020
* Create withCompatText * Move all withText(String) to withCompatText(String) * Add tests * Use custom matchers, no need to creater one * Fix tests * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t view
I removed the scrollListToPosition from assertDisplayedAtPosition as it is done in assertCustomAssertionAtPosition.
isShowOnScreen checks to see if the view is visible to the user.
getShownViewsById retuns a list of all views that match the viewId and are visible to the user.
Fixes #283