Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle and tools #300

Merged
merged 5 commits into from
May 17, 2019
Merged

Update Gradle and tools #300

merged 5 commits into from
May 17, 2019

Conversation

Sloy
Copy link
Member

@Sloy Sloy commented May 17, 2019

I upgraded the Gradle Wrapper version to the latest one. At the same time I had to update to newer versions of the Android Gradle Plugin and the Kotlin Plugin.

This fixes the error when running the project in computers with a recent version of the JDK.
Could not determine java version from '12.0.1'.

@Sloy Sloy requested a review from a team May 17, 2019 10:05
@Sloy Sloy force-pushed the update-gradle branch from 7dc3310 to 373714d Compare May 17, 2019 14:38
@Sloy Sloy merged commit 514b1a0 into master May 17, 2019
@Sloy Sloy deleted the update-gradle branch May 17, 2019 14:53
@CristianGM
Copy link
Member

Cheater, we approved a PR and you changed it later 😒

@Sloy
Copy link
Member Author

Sloy commented May 17, 2019

I asked on slack. That counts 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants