Remove findbugs completely

AdevintaSpain · May 17, 2019 · 7dc3310 · 7dc3310
1 parent 5b295df
commit 7dc3310
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 1,170 deletions.
diff --git a/config/android-quality.gradle b/config/android-quality.gradle
@@ -1,5 +1,4 @@
 apply plugin: 'pmd'
-apply plugin: 'findbugs'
 apply plugin: 'checkstyle'
 
 def isTravis = "true".equals(System.getenv("TRAVIS"))
@@ -8,11 +7,6 @@ pmd {
   ruleSetFiles = files("${project.rootDir}/config/pmd/pmd-ruleset.xml")
 }
 
-findbugs {
-  includeFilter = file("${project.rootDir}/config/findbugs/findbugs-config.xml")
-  excludeFilter = file("${project.rootDir}/config/findbugs/findbugs-excludes.xml")
-}
-
 checkstyle {
   toolVersion = "7.1.1"
   showViolations isTravis
@@ -40,71 +34,8 @@ task pmd(type: Pmd) {
 }
 
 
-// Excludes based on https://github.com/ChaitanyaPramod/findbugs-android
-def androidDataBindingExcludes =
-    ['android/databinding/**/*.class',
-     '**/android/databinding/*Binding.class',
-     '**/BR.*'].asImmutable()
-
-def Collection<String> androidExcludes =
-    ['**/R.class',
-     '**/R$*.class',
-     '**/BuildConfig.*',
-     '**/Manifest*.*',
-     '**/*.bin'
-    ].asImmutable()
-
-def Collection<String> butterKnifeExcludes =
-    ['**/*$ViewInjector*.*',
-     '**/*$ViewBinder*.*'].asImmutable()
-
-def Collection<String> dagger2Excludes =
-    ['**/*_MembersInjector.class',
-     '**/Dagger*Component.class',
-     '**/Dagger*Component$Builder.class',
-     '**/*Module_*Factory.class'].asImmutable()
-
-def Collection<String> defaultExcludes =
-    (androidDataBindingExcludes + androidExcludes + butterKnifeExcludes + dagger2Excludes)
-        .asImmutable()
-
-getVariants().all { variant ->
-  task("findbugs${variant.name.capitalize()}", type: FindBugs) {
-    description "Analyze ${variant.name} code with the findbugs tool"
-    group "Verification"
-
-    source = variant.javaCompile.source
-    classes = project.fileTree(dir: variant.javaCompile.destinationDir, excludes: defaultExcludes)
-    classpath = variant.javaCompile.classpath
-
-    reports {
-      xml.enabled = isTravis
-      html.enabled = !isTravis
-    }
-    dependsOn variant.javaCompile
-  }
-}
-
-task findbugs() {
-  description "Analyze code with the findbugs tool"
-  group "Verification"
-
-  dependsOn tasks.withType(FindBugs)
-}
-
-task checkstyle(type: Checkstyle) {
-  description 'Run checkstyle'
-  group 'verification'
-
-  configFile file("${project.rootDir}/config/checkstyle/checkstyle.xml")
-  configProperties = [rootDir: "${project.rootDir}"]
-  source 'src'
-  include '**/*.java'
-  exclude '**/gen/**'
-  classpath = files()
-}
-
-check.dependsOn 'checkstyle', 'findbugs', 'pmd', 'lint'
+// Exclude
+check.dependsOn 'checkstyle', 'pmd', 'lint'
 
 apply plugin: 'jacoco'