Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows tests #90

Merged
merged 17 commits into from
Nov 23, 2023
Merged

Fix windows tests #90

merged 17 commits into from
Nov 23, 2023

Conversation

gonlairo
Copy link
Contributor

@gonlairo gonlairo commented Oct 3, 2023

Fix #79

@cla-bot cla-bot bot added the CLA signed label Oct 3, 2023
@MMathisLab MMathisLab requested a review from stes October 5, 2023 11:22
stes
stes reviewed Nov 2, 2023
View reviewed changes
Copy link
Member

@stes stes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment, otherwise I think great!

cebra/integrations/sklearn/cebra.py Outdated Show resolved Hide resolved
@gonlairo gonlairo requested a review from MMathisLab November 2, 2023 17:40
@gonlairo gonlairo requested a review from stes November 3, 2023 11:21
stes
stes approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@stes stes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@MMathisLab MMathisLab merged commit 8b9bb1a into AdaptiveMotorControlLab:main Nov 23, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MMathisLab MMathisLab MMathisLab approved these changes

@stes stes stes approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gonlairo @stes @MMathisLab