Fix broadcasting in InfoNCE loss #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #48 in the numerically stabilized version of the InfoNCE loss function. It also adds numerical tests for the infoNCE implementation.
Note: Although we verified that this change does not meaningfully influence the algorithm outputs (e.g., in the demo notebooks), it is not advised to do model comparisons across models trained before (up to 0.3.0rc1) and after (from 0.3.0rc2 onwards) this modification.
Thanks to @mudphudwang for flagging.
Fix #48
Fix https://github.com/AdaptiveMotorControlLab/CEBRA-dev/pull/658