Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing mark in test_datasets.py #52

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

gonlairo
Copy link
Contributor

@gonlairo gonlairo commented Jul 31, 2023

Add mark to test_download_file_successful_download() such that the test will only be run when "requires dataset" is added.

Fix https://github.com/AdaptiveMotorControlLab/CEBRA-dev/pull/656
Fix https://github.com/AdaptiveMotorControlLab/CEBRA-dev/issues/655

@cla-bot cla-bot bot added the CLA signed label Jul 31, 2023
@stes stes force-pushed the fix-mark-test-dataset branch from 440d648 to 268036a Compare July 31, 2023 15:09
@stes stes self-requested a review July 31, 2023 15:09
Copy link
Member

@stes stes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, approved on dev.

Will merge once tests passed.

@stes stes merged commit 6fe5f19 into AdaptiveMotorControlLab:main Jul 31, 2023
@stes stes deleted the fix-mark-test-dataset branch July 31, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants