Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Device in Multisession Training #44

Merged

Conversation

gonlairo
Copy link
Contributor

This pull request addresses a bug in the multisession training functionality of both the sklearn and torch APIs. Previously, irrespective of the user's preference for GPU execution, the training process was limited to CPU only. Our fix ensures that specified accelerators, such as cuda, are utilized. The problem resided in the DatasetCollection, where CPU was set as the default and users were unable to modify this behavior.

Fix https://github.com/AdaptiveMotorControlLab/CEBRA-dev/pull/651.

@cla-bot cla-bot bot added the CLA signed label Jul 12, 2023
@gonlairo gonlairo changed the title fix device in multisession training Fix Device in Multisession Training Jul 12, 2023
@MMathisLab MMathisLab self-requested a review July 13, 2023 06:17
@stes stes self-requested a review July 13, 2023 13:32
Copy link
Member

@stes stes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor edits to the comments, then ready to merge.

cebra/data/datasets.py Outdated Show resolved Hide resolved
tests/test_sklearn.py Outdated Show resolved Hide resolved
@stes stes merged commit b707a5a into AdaptiveMotorControlLab:main Jul 13, 2023
@stes stes deleted the rodrigo/fix-device-multisession branch July 13, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants