-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Device in Multisession Training #44
Merged
stes
merged 13 commits into
AdaptiveMotorControlLab:main
from
gonlairo:rodrigo/fix-device-multisession
Jul 13, 2023
Merged
Fix Device in Multisession Training #44
stes
merged 13 commits into
AdaptiveMotorControlLab:main
from
gonlairo:rodrigo/fix-device-multisession
Jul 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MotorControlLab/CEBRA-dev into rodrigo/fix-device-multisession
gonlairo
changed the title
fix device in multisession training
Fix Device in Multisession Training
Jul 12, 2023
MMathisLab
approved these changes
Jul 13, 2023
stes
reviewed
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor edits to the comments, then ready to merge.
stes
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a bug in the multisession training functionality of both the sklearn and torch APIs. Previously, irrespective of the user's preference for GPU execution, the training process was limited to CPU only. Our fix ensures that specified accelerators, such as cuda, are utilized. The problem resided in the
DatasetCollection
, where CPU was set as the default and users were unable to modify this behavior.Fix https://github.com/AdaptiveMotorControlLab/CEBRA-dev/pull/651.