Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove grid_search_models/ after running tests #26

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

stes
Copy link
Member

@stes stes commented Jun 24, 2023

Our Makefile contains a routine for removing temp files created during testing via make clean_test. One of the added folders for testing the grid search function was not included there, this PR fixes that.

@stes stes requested a review from MMathisLab June 24, 2023 11:44
@cla-bot cla-bot bot added the CLA signed label Jun 24, 2023
@stes stes self-assigned this Jun 24, 2023
@github-actions
Copy link
Contributor

Docstring Coverage Report

Name Total Miss Cover Cover%
main.py 5 1 4 80%
config.py 6 4 2 33%
data/datatypes.py 5 2 3 60%
data/helper.py 6 1 5 83%
data/multi_session.py 12 5 7 58%
datasets/demo.py 8 3 5 62%
datasets/gaussian_mixture.py 3 2 1 33%
datasets/hippocampus.py 7 1 6 86%
datasets/save_dataset.py 4 1 3 75%
datasets/allen/single_session_ca.py 9 3 6 67%
distributions/discrete.py 9 2 7 78%
distributions/multisession.py 5 1 4 80%
integrations/sklearn/helpers.py 2 1 1 50%
integrations/sklearn/metrics.py 3 1 2 67%
integrations/sklearn/utils.py 6 1 5 83%
models/projector.py 12 9 3 25%
------------------------------------------ -------- ------- -------- ---------
TOTAL 396 38 358 90.4%
(45 of 61 files omitted due to complete coverage)

RESULT: PASSED (minimum: 90.0%, actual: 90.4%)

@stes stes added the bug Something isn't working label Jun 24, 2023
@MMathisLab
Copy link
Member

LGTM, but some tests are failing

@stes
Copy link
Member Author

stes commented Jun 26, 2023

Thanks -- failing tests still due to https://github.com/AdaptiveMotorControlLab/CEBRA-dev/pull/647, working on that with @gonlairo

@stes stes force-pushed the stes/file-cleanup-after-tests branch from 799fc8c to 66c1bc8 Compare June 27, 2023 15:17
@stes stes merged commit 89a1d5d into main Jun 27, 2023
@stes stes deleted the stes/file-cleanup-after-tests branch June 27, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants