Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose n_bins argument from align_embeddings #25

Merged
merged 4 commits into from
Jul 12, 2023
Merged

Conversation

stes
Copy link
Member

@stes stes commented Jun 24, 2023

Fix #24

Thanks to @drsax93 for flagging and testing!

I also added the required functions to the docs.

Before After
image image

|

image

@cla-bot cla-bot bot added the CLA signed label Jun 24, 2023
@github-actions
Copy link
Contributor

Docstring Coverage Report

Name Total Miss Cover Cover%
main.py 5 1 4 80%
config.py 6 4 2 33%
data/datatypes.py 5 2 3 60%
data/helper.py 6 1 5 83%
data/multi_session.py 12 5 7 58%
datasets/demo.py 8 3 5 62%
datasets/gaussian_mixture.py 3 2 1 33%
datasets/hippocampus.py 7 1 6 86%
datasets/save_dataset.py 4 1 3 75%
datasets/allen/single_session_ca.py 9 3 6 67%
distributions/discrete.py 9 2 7 78%
distributions/multisession.py 5 1 4 80%
integrations/sklearn/helpers.py 2 1 1 50%
integrations/sklearn/metrics.py 3 1 2 67%
integrations/sklearn/utils.py 6 1 5 83%
models/projector.py 12 9 3 25%
------------------------------------------ -------- ------- -------- ---------
TOTAL 396 38 358 90.4%
(45 of 61 files omitted due to complete coverage)

RESULT: PASSED (minimum: 90.0%, actual: 90.4%)

@drsax93
Copy link

drsax93 commented Jun 26, 2023

This works, decrease the n_bins does the trick!

@stes
Copy link
Member Author

stes commented Jun 26, 2023

Thanks for confirming, @drsax93 --- we will work on shipping this feature in an upcoming version of CEBRA then.

@stes stes force-pushed the stes/expose-num_bins branch from ab44fee to 0faae2b Compare July 12, 2023 02:17
@stes stes requested a review from MMathisLab July 12, 2023 02:41
@stes stes merged commit d37e7f9 into main Jul 12, 2023
@stes stes deleted the stes/expose-num_bins branch July 12, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose n_bins argument to cebra_sklearn_helpers.align_embeddings instead of fixing default value internally
3 participants