Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add goodness of fit metric #202

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

CeliaBenquet
Copy link
Member

  • Add the goodness of fit computation function and wrapper function to be used directly on a cebra.CEBRA model (sklearn implementation only). The goodness of fit computation function can be applied on solver.history (loss) for the pytorch implementation, and in that case the batch size needs to be provided.
  • Add corresponding tests.

Note that it is not implemented for batch size set to None.

@cla-bot cla-bot bot added the CLA signed label Nov 29, 2024
@CeliaBenquet CeliaBenquet self-assigned this Nov 29, 2024
@CeliaBenquet CeliaBenquet added the enhancement New feature or request label Nov 29, 2024
Copy link
Member

@stes stes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of #190, just without tests?

@stes
Copy link
Member

stes commented Nov 29, 2024

Is think that one is almost ready, just one minor issue with a test...

@CeliaBenquet
Copy link
Member Author

Ah yeah right, didn't see that @stes. Happy to review when it's done then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants