Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in pi_vae.py #20

Merged
merged 5 commits into from
Jun 30, 2023
Merged

Conversation

eltociear
Copy link
Contributor

implmentation -> implementation

@cla-bot
Copy link

cla-bot bot commented May 13, 2023

Thank you for your contribution. We require contributors to sign our Contributor License Agreement (CLA). We do not have a signed CLA on file for you. In order for us to review and merge your code, please sign our CLA here. After you signed, you can comment on this PR with @cla-bot check to trigger another check.

@eltociear
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the CLA signed label May 13, 2023
@cla-bot
Copy link

cla-bot bot commented May 13, 2023

Thanks for tagging me. I looked for a signed form under your signature again, and updated the status on this PR. If the check was successful, no further action is needed. If the check was unsuccessful, please see the instructions in my first comment.

@stes stes self-assigned this May 14, 2023
@stes stes self-requested a review May 14, 2023 13:42
@stes
Copy link
Member

stes commented May 14, 2023

Thanks for the contribution, @eltociear --- just fyi, the PR looks fine, the build errors are unrelated to the PR and related to the workflow config. I will look into it and merge this, no further action required on your end.

@stes stes added the documentation Improvements or additions to documentation label Jun 23, 2023
@stes
Copy link
Member

stes commented Jun 23, 2023

Looking into this. Two issues:

In both cases it seems like adding PATs will fix the issue, I will go ahead and try this now.

@stes
Copy link
Member

stes commented Jun 30, 2023

@MMathisLab should pass now, lets see.

Copy link
Member

@stes stes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When merging, let's remove the additional description text from the intermediate commits we did here.

@stes stes merged commit b3818ad into AdaptiveMotorControlLab:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants