Fix linting issues #185
Merged
Fix linting issues #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like my docstring fixes broke some tests. Will fix |
stes
force-pushed
the
stes/fix-linting-issues
branch
from
712c2d9 to
88077ab
Compare
|
@MMathisLab , this is also finally done! should fix all remaining linting errors in ruff. found some actual errors in the code we missed before before the code in the respective section is not fully covered by tests (should be fixed in a future PR) |
- lines too long - unused variables - missing imports - duplicate names for classes
- missing paths - long lines - unused variables - typos
stes
force-pushed
the
stes/fix-linting-issues
branch
from
7ce8453 to
a84a940
Compare
|
@MMathisLab good to go once tests pass? |
MMathisLab
approved these changes
Oct 26, 2024
There was a problem hiding this comment.
Did not locally test, but looking over it looks great, thanks @stes !
|
Ok sth broke Will fix later and then merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #167 , this PR fixes all linting issues. This includes: