[Ellipsis] Improve Regex Error Handling and Code Cleanup #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
This commit introduces the `--exclude-titles` argument to the aw-watcher-window module, allowing users to specify a list of window titles or regular expression patterns to exclude from tracking. This new feature is designed to complement the existing `--exclude-title` flag, providing enhanced flexibility for users who need to exclude multiple window titles without breaking compatibility with existing configurations. Key Changes: - Added the `--exclude-titles` argument to the argparse configuration in `config.py`, enabling the specification of multiple exclusion patterns. - Updated the `heartbeat_loop` function in `main.py` to support both `exclude_title` and `exclude_titles`, with `exclude_titles` allowing for an array of titles to be excluded. - Utilized the `re` module for regex pattern matching against window titles, ensuring case-insensitive comparisons. This enhancement ensures that users can now more precisely control which window titles are excluded from tracking, making the aw-watcher-window module more versatile and user-friendly.
Co-authored-by: Erik Bjäreholt <[email protected]>
…tles` feature for enhanced window title exclusion);
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -92,10 +91,10 @@ | |||
| poll_time=args.poll_time, | |||
| strategy=args.strategy, | |||
| exclude_title=args.exclude_title, | |||
| exclude_titles=[try: re.compile(title, re.IGNORECASE) except re.error: re.compile(re.escape(title), re.IGNORECASE) for title in args.exclude_titles] | |||
Check failure
Code scanning / CodeQL
Syntax error Error
There was a problem hiding this comment.
lol, Ellipsis really butchered this.
There was a problem hiding this comment.
hey @ErikBjare , looking into what happened here...
There was a problem hiding this comment.
@ErikBjare you can get much higher quality out of Ellipsis by adding a Dockerfile and build/test commands so that it can verify its changes - see docs here https://docs.ellipsis.dev/build. We have a playground as well where you can test it out at https://app.ellipsis.dev/
There was a problem hiding this comment.
happy to help get you onboarded to that 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses review comments left by @ErikBjare on PR #99: [Feature] Add
exclude_titlesfeature for enhanced window title exclusionSummary:
Enhanced regex error handling in
heartbeat_loopand cleaned up code in/aw_watcher_window/main.py.Key points:
heartbeat_loopin/aw_watcher_window/main.pyto handle regex errors.You can configure Ellipsis to address comments with a direct commit or a side PR, see docs.
Something look wrong?: If this Pull Request doesn't address the comments left on the above pull request, create a new PR review with more details. For more information, check the documentation.
Generated with ❤️ by ellipsis.dev