Add env variable to check if ldap is external or internal. Default is internal. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need to inject this env variable into Jenkins as a system environment variable so that it can be consumed by jobs? E.g. https://github.com/Accenture/adop-jenkins/blob/master/resources/init.groovy.d/adop_general.groovy#L28 |
|
Renamed "ENABLE_INTERNAL_LDAP" to "LDAP_IS_MODIFIABLE" variable and explained the meaning of it the README.md |
|
I have tested this PR and it works as expected. Need to verify documentation. |
marisbahtins
force-pushed
the
master
branch
2 times, most recently
from
7ccae97 to
c47aa09
Compare
…with LDAP configuration through jenkins, Allowed values true (default) and false.
|
I have tested this change. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "ENABLE_INTERNAL_LDAP" environment variable which tells what LDAP connection we have (external or internal). This environment variable is used in adop-platform-managment repository.