Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing exponent parameter in the generalized_schlick_bsdf, #1539

Merged
merged 2 commits into from
Jul 24, 2022
Merged

Missing exponent parameter in the generalized_schlick_bsdf, #1539

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
287a80f
Missing documentation for the exponent parameter in the generalized_s…
AdrienHerubel Jul 23, 2022
d408ef9
Merge branch 'main' into missing_exponent_schlick
lgritz Jul 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/shaders/stdosl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,7 @@ closure color conductor_bsdf(normal N, vector U, float roughness_x, float roughn
// \param roughness_y Surface roughness in the V direction with a perceptually linear response over its range.
// \param f0 Reflectivity per color channel at facing angles.
// \param f90 Reflectivity per color channel at grazing angles.
// \param exponent Variable exponent for the Schlick Fresnel curve, the default value should be 5
// \param distribution Microfacet distribution. An implementation is expected to support the following distributions: { "ggx" }
// \param thinfilm_thickness Optional float parameter for thickness of an iridescent thin film layer on top of this BSDF. Given in nanometers.
// \param thinfilm_ior Optional float parameter for refraction index of the thin film layer.
Expand Down
2 changes: 2 additions & 0 deletions src/testrender/shading.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ struct MxGeneralizedSchlickParams {
float roughness_y;
Color3 f0;
Color3 f90;
float exponent;
ustring distribution;
// optional
float thinfilm_thickness;
Expand Down Expand Up @@ -292,6 +293,7 @@ register_closures(OSL::ShadingSystem* shadingsys)
CLOSURE_FLOAT_PARAM(MxGeneralizedSchlickParams, roughness_y),
CLOSURE_COLOR_PARAM(MxGeneralizedSchlickParams, f0),
CLOSURE_COLOR_PARAM(MxGeneralizedSchlickParams, f90),
CLOSURE_COLOR_PARAM(MxGeneralizedSchlickParams, exponent),
CLOSURE_STRING_PARAM(MxGeneralizedSchlickParams, distribution),
CLOSURE_FLOAT_KEYPARAM(MxGeneralizedSchlickParams, thinfilm_thickness, "thinfilm_thickness"),
CLOSURE_FLOAT_KEYPARAM(MxGeneralizedSchlickParams, thinfilm_ior, "thinfilm_ior"),
Expand Down