Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing exponent parameter in the generalized_schlick_bsdf, #1539

Merged
merged 2 commits into from
Jul 24, 2022
Merged

Missing exponent parameter in the generalized_schlick_bsdf, #1539

merged 2 commits into from
Jul 24, 2022

Conversation

AdrienHerubel
Copy link
Contributor

Signed-off-by: Adrien Herubel [email protected]

Description

This PR adds the missing documentation for the exponent parameter in generalized_schlick_bsdf, as well as storage for the parameter in the testrender parameter structure.

Checklist:

  • [ x] I have read the contribution guidelines.
  • [ x] I have previously submitted a Contributor License Agreement.
  • [ x] I have updated the documentation, if applicable.
  • [ x] I have ensured that the change is tested somewhere in the testsuite (adding new test cases if necessary).
  • [ x] My code follows the prevailing code style of this project.

@AdrienHerubel
Missing documentation for the exponent parameter in the generalized_s…
287a80f 
…chlick_bsdf, and missing storage for the parameter

Signed-off-by: Adrien Herubel <[email protected]>
fpsunflower
fpsunflower approved these changes Jul 23, 2022
View reviewed changes
Copy link
Contributor

@fpsunflower fpsunflower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@lgritz lgritz merged commit e0d6a21 into AcademySoftwareFoundation:main Jul 24, 2022
lgritz pushed a commit to lgritz/OpenShadingLanguage that referenced this pull request Jul 24, 2022
@AdrienHerubel @lgritz
Missing documentation for the exponent parameter in the generalized_s…
29e8d0b 
…chlick_bsdf, and missing storage for the parameter (AcademySoftwareFoundation#1539)

Signed-off-by: Adrien Herubel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpsunflower fpsunflower fpsunflower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdrienHerubel @fpsunflower @lgritz