Use a project-specific var for whether we're running in CI #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe somebody else is building this as a subproject or has a varible called "CI"? * For our CI runs, set an env variable "OSL_CI" (not just generic "CI"). * Default STOP_ON_WARNING to be off for supported releases, only on by default for main branch where we're actively developing. Because you want downstream users who are building supported releases to not get tripped up when their compiler upgrades and there's a new warning. * Make sure STOP_ON_WARNING is true for our CI runs, even for release branches -- but now check OSL_CI, not CI, in case somebody else has set that. Fixes 1428 Signed-off-by: Larry Gritz <[email protected]>
fpsunflower
approved these changes
Dec 2, 2021
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Dec 3, 2021
…ftwareFoundation#1446) Maybe somebody else is building this as a subproject or has a variable called "CI"? * For our CI runs, set an env variable "OSL_CI" (not just generic "CI"). * Default STOP_ON_WARNING to be off for supported releases, only on by default for main branch where we're actively developing. Because you want downstream users who are building supported releases to not get tripped up when their compiler upgrades and there's a new warning. * Make sure STOP_ON_WARNING is true for our CI runs, even for release branches -- but now check OSL_CI, not CI, in case somebody else has set that. Fixes AcademySoftwareFoundation#1428 Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe somebody else is building this as a subproject or has a variable
called "CI"?
For our CI runs, set an env variable "OSL_CI" (not just generic "CI").
Default STOP_ON_WARNING to be off for supported releases, only on by
default for main branch where we're actively developing. Because you
want downstream users who are building supported releases to not get
tripped up when their compiler upgrades and there's a new warning.
Make sure STOP_ON_WARNING is true for our CI runs, even for release
branches -- but now check OSL_CI, not CI, in case somebody else has
set that.
Fixes #1428
Signed-off-by: Larry Gritz [email protected]