Packaging Failed with STOP_ON_WARNING=OFF #1428
Comments
|
No reponse, It looks like this project is abandoned! |
|
Not abandoned. But you didn't give much information. What errors are you getting? Our CI does test against gcc11, so I'm surprised that you're getting warnings at all. |
You could tell me though!
I was trying to package OSL 1.11.15.0 for mingw-w64 (https://github.com/msys2/MINGW-packages). I don't remember the warnings as the biggest annoying thing was that I couldn't disable Werror on CI environment. |
|
Apologies; I must have been busy when the issue was filed, and it slipped through the cracks. I wasn't purposely trying to ignore it. (Note to TSC members and other developers in the OSL community: this isn't all supposed to be on me!) The "CI" issue is a good point. I will propose a fix to this tomorrow. |
|
Proposed fix: #1446 |
Maybe somebody else is building this as a subproject or has a variable called "CI"? * For our CI runs, set an env variable "OSL_CI" (not just generic "CI"). * Default STOP_ON_WARNING to be off for supported releases, only on by default for main branch where we're actively developing. Because you want downstream users who are building supported releases to not get tripped up when their compiler upgrades and there's a new warning. * Make sure STOP_ON_WARNING is true for our CI runs, even for release branches -- but now check OSL_CI, not CI, in case somebody else has set that. Fixes #1428 Signed-off-by: Larry Gritz <[email protected]>
…ftwareFoundation#1446) Maybe somebody else is building this as a subproject or has a variable called "CI"? * For our CI runs, set an env variable "OSL_CI" (not just generic "CI"). * Default STOP_ON_WARNING to be off for supported releases, only on by default for main branch where we're actively developing. Because you want downstream users who are building supported releases to not get tripped up when their compiler upgrades and there's a new warning. * Make sure STOP_ON_WARNING is true for our CI runs, even for release branches -- but now check OSL_CI, not CI, in case somebody else has set that. Fixes AcademySoftwareFoundation#1428 Signed-off-by: Larry Gritz <[email protected]>
Problem
Packaging OSL Failed because it forces "-Werror" on CI environment even with STOP_ON_WARNING=OFF
https://github.com/AcademySoftwareFoundation/OpenShadingLanguage/blob/master/src/cmake/compiler.cmake#L90
Expected behavior:
CI doesn't always mean testing.
Actual behavior:
Many warnings from GCC-11 treated as errors, compilation aborted.
Steps to Reproduce
Versions
The text was updated successfully, but these errors were encountered: