Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use _WIN32 instead of _MSC_VER to fix mingw build #245

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

cary-ilm
Copy link
Member

Addresses #233.

I looked at other usage of _MSC_VER and didn't see anything obviously amiss, but Windows/mingw users please confirm.

Signed-off-by: Cary Phillips [email protected]

Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to guard these with SDK, not compiler.

@cary-ilm cary-ilm merged commit b9f9263 into AcademySoftwareFoundation:main Mar 17, 2022
cary-ilm added a commit to cary-ilm/Imath that referenced this pull request Mar 22, 2022
…ndation#245)

* Use _WIN32 instead of _MSC_VER to fix mingw build

Signed-off-by: Cary Phillips <[email protected]>

* fix formatting

Signed-off-by: Cary Phillips <[email protected]>
cary-ilm added a commit that referenced this pull request Mar 25, 2022
* Use _WIN32 instead of _MSC_VER to fix mingw build

Signed-off-by: Cary Phillips <[email protected]>

* fix formatting

Signed-off-by: Cary Phillips <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants