-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect usage of _MSC_VER #233
Comments
OTOH, you'd also want to enable IMATH_INSTALL_PKG_CONFIG for MINGW, but not for MSVC builds: Lines 39 to 46 in 3206446
|
pkgconfig can be enabled with |
Yeah, I meant "by default", not a big deal indeed. |
Should be resolved by #245. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
User @Biswa96 has reported that we are using _MSC_VER (detect the usage of the Microsoft Visual C compiler) where we are intending to use _WIN32 (detect that the target platform is Windows). We should check the uses of _MSC_VER and correct them as necessary. Thank you @bisaw96 for the report.
The text was updated successfully, but these errors were encountered: