Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect usage of _MSC_VER #233

Closed
meshula opened this issue Jan 28, 2022 · 4 comments
Closed

Incorrect usage of _MSC_VER #233

meshula opened this issue Jan 28, 2022 · 4 comments

Comments

@meshula
Copy link
Contributor

meshula commented Jan 28, 2022

User @Biswa96 has reported that we are using _MSC_VER (detect the usage of the Microsoft Visual C compiler) where we are intending to use _WIN32 (detect that the target platform is Windows). We should check the uses of _MSC_VER and correct them as necessary. Thank you @bisaw96 for the report.

@kmilos
Copy link

kmilos commented Feb 8, 2022

OTOH, you'd also want to enable IMATH_INSTALL_PKG_CONFIG for MINGW, but not for MSVC builds:

# Whether to generate and install a pkg-config file Imath.pc on
if(WIN32)
option(IMATH_INSTALL_PKG_CONFIG "Install Imath.pc file" OFF)
option(IMATH_INSTALL_SYM_LINK "Create symbolic links for shared objects" OFF)
else()
option(IMATH_INSTALL_PKG_CONFIG "Install Imath.pc file" ON)
option(IMATH_INSTALL_SYM_LINK "Create symbolic links for shared objects" ON)
endif()

@Biswa96
Copy link

Biswa96 commented Feb 8, 2022

pkgconfig can be enabled with IMATH_INSTALL_PKG_CONFIG option. So, I didn't think to change that default behavior.

@kmilos
Copy link

kmilos commented Feb 8, 2022

Yeah, I meant "by default", not a big deal indeed.

@cary-ilm
Copy link
Member

Should be resolved by #245.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants